Skip to content

Commit ea730ff

Browse files
nevedarenSkCQ
authored andcommitted
[perf] Change fatal error to error log when querying traceids.
This prevents the program from crashing when there's an error querying trace IDs, instead logging the error and allowing the program to continue. Originally this was set to Fatal, because the error is never supposed to happen in this code (it's fully local). But: we shouldn't crash even in the case of bugs, and also the context can be cancelled. Fatal logs are discouraged to be used on prod. Bug: 446827886 Change-Id: Id4ce1704e2f71fa3ca1aac3c4b9d5756d524bc9c Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1061196 Reviewed-by: Marcin Mordecki <[email protected]> Commit-Queue: Anri Sidorov <[email protected]> Commit-Queue: Marcin Mordecki <[email protected]>
1 parent 789ac4a commit ea730ff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

perf/go/tracestore/sqltracestore/inmemorytraceparams.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ func (tp *InMemoryTraceParams) QueryTraceIDs(ctx context.Context, tileNumber typ
277277
return nil
278278
})
279279
if err != nil {
280-
sklog.Fatal(err)
280+
sklog.Errorf("Error querying traceids. %s", err)
281281
}
282282
}()
283283
}

0 commit comments

Comments
 (0)