Skip to content

Commit 22e703c

Browse files
Maggie DongSkCQ
authored andcommitted
Fix delta color display issue.
Updated anomalies table css selector to target the dynamic table ID. Bug: b/467017324 Change-Id: Ic5ff005d5677e843e137c74158499d5a09d87615 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1123011 Commit-Queue: Maggie Dong <[email protected]> Reviewed-by: Anri Sidorov <[email protected]>
1 parent 37ecf9f commit 22e703c

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

perf/modules/anomalies-table-sk/anomalies-table-sk.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,14 @@ anomalies-table-sk {
5656
.regression {
5757
color: rgb(255, 0, 0);
5858
}
59+
60+
td.delta.improvement {
61+
color: rgb(0, 128, 0);
62+
}
63+
td.delta.regression {
64+
color: rgb(255, 0, 0);
65+
}
66+
5967
#change_direction {
6068
text-align: center;
6169
width: var(--percent-changed-width, 50px);

perf/modules/anomalies-table-sk/anomalies-table-sk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ export class AnomaliesTableSk extends ElementSk implements KeyboardShortcutHandl
654654
? html`<spinner-sk active></spinner-sk>` // Show spinner if loading
655655
: html`
656656
<button
657-
id="trendingicon-link"
657+
class="trendingicon-link"
658658
@click=${async () => {
659659
const newTab = window.open('', '_blank');
660660
if (newTab) {

perf/modules/anomalies-table-sk/anomalies-table-sk_po.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class AnomaliesTableSkPO extends PageObject {
5050
}
5151

5252
get trendingIconLink(): PageObjectElementList {
53-
return this.bySelectorAll('button#trendingicon-link');
53+
return this.bySelectorAll('button.trendingicon-link');
5454
}
5555

5656
get groupingSettingsDetails(): PageObjectElement {
@@ -93,9 +93,9 @@ export class AnomaliesTableSkPO extends PageObject {
9393
}
9494

9595
async clickTrendingIconButton(index: number): Promise<void> {
96+
await this.clickExpandButton(index);
9697
const trendingLinkList = await this.trendingIconLink;
9798
const trendingLink = trendingLinkList.item(index);
98-
await this.clickExpandButton(index);
9999
await (await trendingLink).click();
100100
}
101101

0 commit comments

Comments
 (0)