[bazel] Move google_chrome to MODULE.bazel

This just wraps the existing repository_rule into a module_extension and
fixes the resulting path.

Bug: b/458681039
Change-Id: Iccbaa4393ab68d48842d28bdf61dc01e3dd7d4e1
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1122263
Reviewed-by: Kaylee Lubick <[email protected]>
Commit-Queue: Kaylee Lubick <[email protected]>
Auto-Submit: Eric Boren <[email protected]>

Author: erock2112

MODULE.bazel

@@ -650,3 +650,12 @@ http_file(
 google_cloud_sdk = use_extension("//bazel/external:google_cloud_sdk.bzl", "google_cloud_sdk")
 google_cloud_sdk.download(name = "google_cloud_sdk")
 use_repo(google_cloud_sdk, "google_cloud_sdk")
+
+####################################################################################################
+# Google Chrome and Fonts (needed for Karma and Puppeteer tests, respectively).
+####################################################################################################
+
+# TODO(borenet): we should be able to use this from rules_browsers.
+google_chrome = use_extension("//bazel/external:google_chrome.bzl", "google_chrome")
+google_chrome.download(name = "google_chrome")
+use_repo(google_chrome, "google_chrome")

MODULE.bazel.lock

@@ -32,12 +32,3 @@ load("@bazel_toolchains//rules/exec_properties:exec_properties.bzl", "rbe_exec_p
 rbe_exec_properties(
     name = "exec_properties",
 )
-
-# #################################################################################
-# # Google Chrome and Fonts (needed for Karma and Puppeteer tests, respectively). #
-# #################################################################################
-
-# TODO(borenet): we should be able to use this from rules_browsers.
-load("//bazel/external:google_chrome.bzl", "google_chrome")
-
-google_chrome(name = "google_chrome")

WORKSPACE

@@ -53,7 +53,7 @@ _DEB_PACKAGES_LINUX_AMD64 = [
     },
 ]
 
-def _google_chrome_impl(repository_ctx):
+def _google_chrome_repo_impl(repository_ctx):
     is_linux = repository_ctx.os.name.lower().startswith("linux")
 
     if not is_linux:
@@ -395,7 +395,24 @@ filegroup(
 )
 """)
 
-google_chrome = repository_rule(
-    implementation = _google_chrome_impl,
+_google_chrome = repository_rule(
+    implementation = _google_chrome_repo_impl,
     doc = "Hermetically installs Google Chrome, and all required libraries and fonts.",
 )
+
+_download = tag_class(attrs = {
+    "name": attr.string(mandatory = True),
+})
+
+def _google_chrome_impl(ctx):
+    for module in ctx.modules:
+        for tag in module.tags.download:
+            _google_chrome(name = tag.name)
+
+google_chrome = module_extension(
+    doc = "Bzlmod extension used to hermetically download Google Chrome, and all required libraries and fonts.",
+    implementation = _google_chrome_impl,
+    tag_classes = {
+        "download": _download,
+    },
+)

bazel/external/google_chrome.bzl

@@ -22,7 +22,7 @@ const isBazelTest = !process.env.BUILD_WORKSPACE_DIRECTORY; // Set when running
 const bazelRunfilesDir = `${process.env.RUNFILES_DIR}/${process.env.TEST_WORKSPACE}`;
 
 // Forces Karma to use the Bazel-downloaded Google Chrome browser.
-process.env.CHROME_BIN = `${bazelRunfilesDir}/external/google_chrome/opt/google/chrome/chrome`;
+process.env.CHROME_BIN = `${bazelRunfilesDir}/external/_main~google_chrome~google_chrome/opt/google/chrome/chrome`;
 
 module.exports = function (config) {
   config.set({

debugger-app/modules/debugger-page-sk/debugger.karma.conf.js

@@ -26,7 +26,7 @@ const isBazelTest = !process.env.BUILD_WORKSPACE_DIRECTORY; // Set when running
 const bazelRunfilesDir = `${process.env.RUNFILES_DIR}/${process.env.TEST_WORKSPACE}`;
 
 // Forces Karma to use the Bazel-downloaded Google Chrome browser.
-process.env.CHROME_BIN = `${bazelRunfilesDir}/external/google_chrome/opt/google/chrome/chrome`;
+process.env.CHROME_BIN = `${bazelRunfilesDir}/external/_main~google_chrome~google_chrome/opt/google/chrome/chrome`;
 
 module.exports = function (config) {
   config.set({

infra-sk/karma_test/karma.conf.js

@@ -33,7 +33,7 @@ const isBazelTest = !process.env.BUILD_WORKSPACE_DIRECTORY; // Set when running
 const bazelRunfilesDir = `${process.env.RUNFILES_DIR}/${process.env.TEST_WORKSPACE}`;
 
 // Forces Karma to use the Bazel-downloaded Google Chrome browser.
-process.env.CHROME_BIN = `${bazelRunfilesDir}/external/google_chrome/opt/google/chrome/chrome`;
+process.env.CHROME_BIN = `${bazelRunfilesDir}/external/_main~google_chrome~google_chrome/opt/google/chrome/chrome`;
 
 module.exports = function (config) {
   config.set({