Skip to content

Commit 09e3dcf

Browse files
nevedarenSkCQ
authored andcommitted
[perf][UI] Add unit tests for explore-multi-sk.
This change introduces a new test file `explore-multi-sk_test.ts` to provide comprehensive unit test coverage for the `ExploreMultiSk` component. A minor fix is also included in `explore-multi-sk.ts` to correctly access the index from the `x-axis-toggled` event detail. Change-Id: Iaf13f6a937fe23b84cf60aeed76c0224b275abeb Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1033016 Commit-Queue: Tony Seaward <[email protected]> Reviewed-by: Tony Seaward <[email protected]> Auto-Submit: Anri Sidorov <[email protected]>
1 parent 9d3e23b commit 09e3dcf

File tree

3 files changed

+385
-3
lines changed

3 files changed

+385
-3
lines changed

perf/modules/explore-multi-sk/BUILD.bazel

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("//infra-sk:index.bzl", "sk_demo_page_server", "sk_element", "sk_page")
1+
load("//infra-sk:index.bzl", "karma_test", "sk_demo_page_server", "sk_element", "sk_page")
22

33
sk_element(
44
name = "explore-multi-sk",
@@ -51,3 +51,22 @@ sk_page(
5151
ts_deps = ["//perf/modules/common:test-util_ts_lib"],
5252
ts_entry_point = "explore-multi-sk-demo.ts",
5353
)
54+
55+
karma_test(
56+
name = "explore-multi-sk_test",
57+
src = "explore-multi-sk_test.ts",
58+
deps = [
59+
":explore-multi-sk",
60+
"//:node_modules/@types/chai",
61+
"//:node_modules/@types/sinon",
62+
"//:node_modules/chai",
63+
"//:node_modules/fetch-mock",
64+
"//:node_modules/sinon",
65+
"//golden/modules/pagination-sk",
66+
"//infra-sk/modules:test_util_ts_lib",
67+
"//perf/modules/common:test-util_ts_lib",
68+
"//perf/modules/explore-simple-sk",
69+
"//perf/modules/json:index_ts_lib",
70+
"//perf/modules/plot-google-chart-sk",
71+
],
72+
)

perf/modules/explore-multi-sk/explore-multi-sk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ import { PaginationSkPageChangedEventDetail } from '../../../golden/modules/pagi
6161
import { PickerFieldSk } from '../picker-field-sk/picker-field-sk';
6262
import { CommitLinks } from '../point-links-sk/point-links-sk';
6363

64-
class State {
64+
export class State {
6565
begin: number = Math.floor(Date.now() / 1000 - DEFAULT_RANGE_S);
6666

6767
end: number = Math.floor(Date.now() / 1000);
@@ -941,7 +941,7 @@ export class ExploreMultiSk extends ElementSk {
941941
const graphs = this.graphDiv!.querySelectorAll('explore-simple-sk');
942942
graphs.forEach((graph, i) => {
943943
// Skip graph that sent the event.
944-
if (i !== e.detail) {
944+
if (i !== e.detail.index) {
945945
(graph as ExploreSimpleSk).updateXAxis(e.detail.domain);
946946
}
947947
});

0 commit comments

Comments
 (0)