Skip to content

Commit df49880

Browse files
committed
cleanup: remove dep lodash.pickBy
It turns out that the code calling this was unreachable.
1 parent 45834a8 commit df49880

File tree

3 files changed

+0
-36
lines changed

3 files changed

+0
-36
lines changed

package-lock.json

Lines changed: 0 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
"bindings": "^1.2.1",
3333
"delay": "^4.0.1",
3434
"findit2": "^2.2.3",
35-
"lodash.pickby": "^4.6.0",
3635
"nan": "^2.12.1",
3736
"node-pre-gyp": "^0.12.0",
3837
"p-limit": "^2.0.0",
@@ -43,7 +42,6 @@
4342
"split": "^1.0.1"
4443
},
4544
"devDependencies": {
46-
"@types/lodash.pickby": "^4.6.5",
4745
"@types/mocha": "^5.0.0",
4846
"@types/node": "^10.0.3",
4947
"@types/p-limit": "^2.0.0",

ts/third_party/cloud-debug-nodejs/src/agent/io/scanner.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import * as crypto from 'crypto';
1818
import * as events from 'events';
1919
import * as fs from 'fs';
2020
import * as path from 'path';
21-
import pickBy = require('lodash.pickby');
2221

2322
// TODO: Make this more precise.
2423
const findit: (dir: string) => events.EventEmitter = require('findit2');
@@ -40,7 +39,6 @@ export interface ScanStats {
4039
export interface ScanResults {
4140
errors(): Map<string, Error>;
4241
all(): ScanStats;
43-
selectStats(regex: RegExp): ScanStats;
4442
selectFiles(regex: RegExp, baseDir: string): string[];
4543
hash?: string;
4644
}
@@ -73,18 +71,6 @@ class ScanResultsImpl implements ScanResults {
7371
return this.stats;
7472
}
7573

76-
/**
77-
* Used to get the file scan results for only the files
78-
* whose filenames match the specified regex.
79-
*
80-
* @param {regex} regex The regex that tests a filename
81-
* to determine if the scan results for that filename
82-
* should be included in the returned results.
83-
*/
84-
selectStats(regex: RegExp): ScanStats|{} {
85-
return pickBy(this.stats, (_, key) => regex.test(key));
86-
}
87-
8874
/**
8975
* Used to get the only the file paths in the scan results
9076
* where the filenames match the specified regex and are

0 commit comments

Comments
 (0)