Skip to content

Commit c8f1164

Browse files
nolanmar511kalyanac
authored andcommitted
fix: fix error messages which appear in system tests (#21)
1 parent ebb9231 commit c8f1164

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"check": "gts check",
1212
"clean": "gts clean && node-gyp clean",
1313
"codecov": "nyc report --reporter=json && codecov -f coverage/*.json",
14-
"compile": "tsc -p . && node-pre-gyp build",
14+
"compile": "tsc -p .",
1515
"fix": "gts fix",
1616
"lint": "gts check",
1717
"docs": "echo 'no docs yet'",
1818
"prepare": "npm run compile",
19-
"pretest": "npm run compile",
19+
"pretest": "npm run compile && node-pre-gyp build",
2020
"posttest": "npm run check && npm run license-check",
2121
"proto": "npm run proto:profile",
2222
"proto:profile": "mkdir -p proto && pbjs -t static-module -w commonjs -o proto/profile.js third_party/proto/profile.proto && pbts -o proto/profile.d.ts proto/profile.js",

system-test/system_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ retry() {
5252
# Display commands being run.
5353
set -x
5454
55+
# Fail on any error.
56+
set -eo pipefail
57+
5558
# Note directory from which test is being run.
5659
BASE_DIR=$(pwd)
5760

tools/build.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,8 @@ do
3535
cp -r build/stage/* "${ARTIFACTS_OUT}/"
3636
rm -rf build
3737
done
38+
39+
# Remove node_modules directory. When this script is run in a docker container
40+
# with user root, then a system test running after this script cannot run npm
41+
# install.
42+
rm -r node_modules

0 commit comments

Comments
 (0)