chore: add backoff to retry function used in e2e test (#120)

* chore: add backoff to retry function used in e2e test

* address comments

Author: nolanmar511

system-test/system_test.sh

@@ -6,9 +6,7 @@ trap "echo '** AT LEAST ONE OF TESTS FAILED **'" ERR
 # Fail on any error, show commands run.
 set -eox pipefail
 
-retry() {
-  "${@}" || "${@}" || "${@}" || exit $?
-}
+. $(dirname $0)/../tools/retry.sh
 
 cd $(dirname $0)
 

system-test/test.sh

@@ -2,9 +2,7 @@
 
 trap "echo '** TEST FAILED **'" ERR
 
-retry() {
-  "${@}" || "${@}" || "${@}" || return 1
-}
+. $(dirname $0)/../tools/retry.sh
 
 function timeout_after() {
   # timeout on Node 11 alpine image requires -t to specify time.

tools/build/linux_build_and_test.sh

@@ -14,9 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-retry() {
-  "${@}" || "${@}" || "${@}" || exit $?
-}
+. $(dirname $0)/../retry.sh
 
 # Fail on any error.
 set -e pipefail

tools/publish.sh

@@ -13,12 +13,8 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-retry() {
-  for i in {1..3}; do
-    "${@}" && return 0
-  done
-  return 1
-}
+
+. $(dirname $0)/retry.sh
 
 set -eo pipefail
 

tools/retry.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+
+# Copyright 2020 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+retry() {
+  for attempt in {1..3}; do
+    [ $attempt == 1 ] || sleep 10  # Backing off after a failed attempt.
+    "${@}" && return 0
+  done
+  return 1
+}