Use Preconditions in more places.

...by running the forthcoming https://errorprone.info/bugpattern/PreferPreconditions.

RELNOTES=n/a
PiperOrigin-RevId: 888270599

Author: cpovirk

android/guava-testlib/src/com/google/common/collect/testing/AbstractIteratorTester.java

@@ -16,6 +16,7 @@
 
 package com.google.common.collect.testing;
 
+import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.collect.testing.Helpers.copyToList;
 import static com.google.common.collect.testing.Helpers.copyToSet;
 import static java.lang.System.arraycopy;
@@ -287,9 +288,7 @@ public enum KnownOrder {
     // periodically we should manually try (steps * 3 / 2) here; all tests but
     // one should still pass (testVerifyGetsCalled()).
     stimuli = (Stimulus<E, ? super I>[]) new Stimulus<?, ?>[steps];
-    if (!elementsToInsertIterable.iterator().hasNext()) {
-      throw new IllegalArgumentException();
-    }
+    checkArgument(elementsToInsertIterable.iterator().hasNext());
     elementsToInsert = Helpers.cycle(elementsToInsertIterable);
     this.features = copyToSet(features);
     this.expectedElements = copyToList(expectedElements);

android/guava-testlib/src/com/google/common/collect/testing/FeatureSpecificTestSuiteBuilder.java

@@ -16,6 +16,7 @@
 
 package com.google.common.collect.testing;
 
+import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.collect.testing.Helpers.copyToSet;
 import static com.google.common.collect.testing.Helpers.getMethod;
 import static com.google.common.collect.testing.features.FeatureUtil.addImpliedFeatures;
@@ -134,11 +135,10 @@ public Set<Feature<?>> getFeatures() {
   /** Configures this builder produce a TestSuite with the given name. */
   @CanIgnoreReturnValue
   public B named(String name) {
-    if (name.contains("(")) {
-      throw new IllegalArgumentException(
-          "Eclipse hides all characters after "
-              + "'('; please use '[]' or other characters instead of parentheses");
-    }
+    checkArgument(
+        !name.contains("("),
+        "Eclipse hides all characters after "
+            + "'('; please use '[]' or other characters instead of parentheses");
     this.name = name;
     return self();
   }

android/guava-testlib/src/com/google/common/collect/testing/Helpers.java

@@ -16,6 +16,7 @@
 
 package com.google.common.collect.testing;
 
+import static com.google.common.base.Preconditions.checkNotNull;
 import static java.lang.Math.max;
 import static java.util.Arrays.asList;
 import static java.util.Collections.singletonMap;
@@ -480,11 +481,7 @@ public abstract static class NullsBefore implements Comparator<@Nullable String>
     private final String justAfterNull;
 
     protected NullsBefore(String justAfterNull) {
-      if (justAfterNull == null) {
-        throw new NullPointerException();
-      }
-
-      this.justAfterNull = justAfterNull;
+      this.justAfterNull = checkNotNull(justAfterNull);
     }
 
     @Override

android/guava-testlib/src/com/google/common/collect/testing/MinimalCollection.java

@@ -16,6 +16,7 @@
 
 package com.google.common.collect.testing;
 
+import static com.google.common.base.Preconditions.checkNotNull;
 import static java.lang.System.arraycopy;
 import static java.util.Arrays.asList;
 
@@ -77,9 +78,7 @@ public int size() {
   public boolean contains(@Nullable Object object) {
     if (!allowNulls) {
       // behave badly
-      if (object == null) {
-        throw new NullPointerException();
-      }
+      checkNotNull(object);
     }
     Platform.checkCast(type, object); // behave badly
     return asList(contents).contains(object);

android/guava-testlib/src/com/google/common/collect/testing/SafeTreeMap.java

@@ -16,6 +16,8 @@
 
 package com.google.common.collect.testing;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
 import com.google.common.annotations.GwtIncompatible;
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import java.io.Serializable;
@@ -62,10 +64,7 @@ public SafeTreeMap(SortedMap<K, ? extends V> map) {
   }
 
   private SafeTreeMap(NavigableMap<K, V> delegate) {
-    this.delegate = delegate;
-    if (delegate == null) {
-      throw new NullPointerException();
-    }
+    this.delegate = checkNotNull(delegate);
     for (K k : keySet()) {
       checkValid(k);
     }

android/guava-tests/benchmark/com/google/common/util/concurrent/MonitorBasedArrayBlockingQueue.java

@@ -16,6 +16,9 @@
 
 package com.google.common.util.concurrent;
 
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
+
 import com.google.common.annotations.GwtIncompatible;
 import com.google.common.annotations.J2ktIncompatible;
 import com.google.common.collect.ObjectArrays;
@@ -168,7 +171,7 @@ public MonitorBasedArrayBlockingQueue(int capacity) {
    * @throws IllegalArgumentException if {@code capacity} is less than 1
    */
   public MonitorBasedArrayBlockingQueue(int capacity, boolean fair) {
-    if (capacity <= 0) throw new IllegalArgumentException();
+    checkArgument(capacity > 0);
     this.items = newEArray(capacity);
     monitor = new Monitor(fair);
     notEmpty =
@@ -202,7 +205,7 @@ public boolean isSatisfied() {
    */
   public MonitorBasedArrayBlockingQueue(int capacity, boolean fair, Collection<? extends E> c) {
     this(capacity, fair);
-    if (capacity < c.size()) throw new IllegalArgumentException();
+    checkArgument(capacity >= c.size());
 
     for (E e : c) add(e);
   }
@@ -239,7 +242,7 @@ public boolean add(E e) {
   @CanIgnoreReturnValue
   @Override
   public boolean offer(E e) {
-    if (e == null) throw new NullPointerException();
+    checkNotNull(e);
     Monitor monitor = this.monitor;
     if (monitor.enterIf(notFull)) {
       try {
@@ -263,8 +266,7 @@ public boolean offer(E e) {
   @CanIgnoreReturnValue
   @Override
   public boolean offer(E e, long timeout, TimeUnit unit) throws InterruptedException {
-
-    if (e == null) throw new NullPointerException();
+    checkNotNull(e);
     Monitor monitor = this.monitor;
     if (monitor.enterWhen(notFull, timeout, unit)) {
       try {
@@ -287,7 +289,7 @@ public boolean offer(E e, long timeout, TimeUnit unit) throws InterruptedExcepti
    */
   @Override
   public void put(E e) throws InterruptedException {
-    if (e == null) throw new NullPointerException();
+    checkNotNull(e);
     Monitor monitor = this.monitor;
     monitor.enterWhen(notFull);
     try {
@@ -589,8 +591,8 @@ public void clear() {
   @CanIgnoreReturnValue
   @Override
   public int drainTo(Collection<? super E> c) {
-    if (c == null) throw new NullPointerException();
-    if (c == this) throw new IllegalArgumentException();
+    checkNotNull(c);
+    checkArgument(c != this);
     E[] items = this.items;
     Monitor monitor = this.monitor;
     monitor.enter();
@@ -624,8 +626,8 @@ public int drainTo(Collection<? super E> c) {
   @CanIgnoreReturnValue
   @Override
   public int drainTo(Collection<? super E> c, int maxElements) {
-    if (c == null) throw new NullPointerException();
-    if (c == this) throw new IllegalArgumentException();
+    checkNotNull(c);
+    checkArgument(c != this);
     if (maxElements <= 0) return 0;
     E[] items = this.items;
     Monitor monitor = this.monitor;

android/guava-tests/benchmark/com/google/common/util/concurrent/MonitorBasedPriorityBlockingQueue.java

@@ -16,6 +16,7 @@
 
 package com.google.common.util.concurrent;
 
+import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
 
 import com.google.common.annotations.GwtIncompatible;
@@ -442,8 +443,8 @@ public String toString() {
   @CanIgnoreReturnValue // pushed down from class to method
   @Override
   public int drainTo(Collection<? super E> c) {
-    if (c == null) throw new NullPointerException();
-    if (c == this) throw new IllegalArgumentException();
+    checkNotNull(c);
+    checkArgument(c != this);
     Monitor monitor = this.monitor;
     monitor.enter();
     try {
@@ -468,8 +469,8 @@ public int drainTo(Collection<? super E> c) {
   @CanIgnoreReturnValue // pushed down from class to method
   @Override
   public int drainTo(Collection<? super E> c, int maxElements) {
-    if (c == null) throw new NullPointerException();
-    if (c == this) throw new IllegalArgumentException();
+    checkNotNull(c);
+    checkArgument(c != this);
     if (maxElements <= 0) return 0;
     Monitor monitor = this.monitor;
     monitor.enter();

android/guava/src/com/google/common/collect/MapMakerInternalMap.java

@@ -14,6 +14,7 @@
 
 package com.google.common.collect;
 
+import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.collect.CollectPreconditions.checkRemove;
 import static java.lang.Math.min;
@@ -243,9 +244,8 @@ private MapMakerInternalMap(MapMaker builder, InternalEntryHelper<K, V, E, S> en
         && builder.getValueStrength() == Strength.STRONG) {
       return new MapMakerInternalMap<>(builder, WeakKeyDummyValueEntry.Helper.instance());
     }
-    if (builder.getValueStrength() == Strength.WEAK) {
-      throw new IllegalArgumentException("Map cannot have both weak and dummy values");
-    }
+    checkArgument(
+        builder.getValueStrength() != Strength.WEAK, "Map cannot have both weak and dummy values");
     throw new AssertionError();
   }
 

android/guava/src/com/google/common/io/ByteStreams.java

@@ -493,9 +493,7 @@ public static ByteArrayDataOutput newDataOutput() {
   public static ByteArrayDataOutput newDataOutput(int size) {
     // When called at high frequency, boxing size generates too much garbage,
     // so avoid doing that if we can.
-    if (size < 0) {
-      throw new IllegalArgumentException(String.format("Invalid size: %s", size));
-    }
+    checkArgument(size >= 0, "Invalid size: %s", size);
     return newDataOutput(new ByteArrayOutputStream(size));
   }
 

android/guava/src/com/google/common/math/Quantiles.java

@@ -489,10 +489,10 @@ private static double interpolate(double lower, double upper, double remainder,
   }
 
   private static void checkIndex(int index, int scale) {
-    if (index < 0 || index > scale) {
-      throw new IllegalArgumentException(
-          "Quantile indexes must be between 0 and the scale, which is " + scale);
-    }
+    checkArgument(
+        index >= 0 && index <= scale,
+        "Quantile indexes must be between 0 and the scale, which is %s",
+        scale);
   }
 
   private static double[] longsToDoubles(long[] longs) {