Skip to content

fix: agent generate config err #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2025

Conversation

simonwei97
Copy link
Contributor

@simonwei97 simonwei97 commented Jun 11, 2025

Code Update

I modified both _get_completion_inputs and generate_content_async functions, the associate file is src/google/adk/models/lite_llm.py.

Test Case

unittests

  • reomve useless lib json.
  • remove duplicate case test_generate_content_async (same code L430-L507)
  • add test_get_completion_inputs_generation_params for func _get_completion_inputs

Fixes: #1302

@hangfei hangfei requested a review from genquan9 June 12, 2025 03:49
@hangfei
Copy link
Collaborator

hangfei commented Jun 12, 2025

@genquan9 Could you help review this change?

Copy link
Contributor

@genquan9 genquan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the help!
The change is great in general!
I only added minor comments.
Could you resolve the comments?

@simonwei97
Copy link
Contributor Author

Thanks a lot for the help! The change is great in general! I only added minor comments. Could you resolve the comments?

@genquan9 Thanks for your suggestion. I fixed the problem mentioned in above comments.

Copy link
Contributor

@genquan9 genquan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@genquan9 genquan9 merged commit badbcbd into google:main Jun 16, 2025
9 checks passed
@simonwei97 simonwei97 deleted the fix/agent-generate-config branch June 17, 2025 01:30
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
* fix: agent generate config err

* fix: resovle comment

---------

Co-authored-by: Hangfei Lin <[email protected]>
Co-authored-by: genquan9 <[email protected]>
seanzhou1023 pushed a commit to soundTricker/adk-python that referenced this pull request Jul 11, 2025
* fix: agent generate config err

* fix: resovle comment

---------

Co-authored-by: Hangfei Lin <[email protected]>
Co-authored-by: genquan9 <[email protected]>
pandasanjay pushed a commit to pandasanjay/adk-python that referenced this pull request Jul 28, 2025
* fix: agent generate config err

* fix: resovle comment

---------

Co-authored-by: Hangfei Lin <[email protected]>
Co-authored-by: genquan9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLM Generation Config(generate_content_config) does not work.
3 participants