Skip to content

Commit f03f167

Browse files
DeanChensjcopybara-github
authored andcommitted
chore: Return explict None type for DELETE endpoints
The HTTP response code will become 204 No Content instead of 200. PiperOrigin-RevId: 796123628
1 parent 43f302c commit f03f167

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

src/google/adk/cli/adk_web_server.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,14 @@ async def create_session(
457457
logger.info("New session created")
458458
return session
459459

460+
@app.delete("/apps/{app_name}/users/{user_id}/sessions/{session_id}")
461+
async def delete_session(
462+
app_name: str, user_id: str, session_id: str
463+
) -> None:
464+
await self.session_service.delete_session(
465+
app_name=app_name, user_id=user_id, session_id=session_id
466+
)
467+
460468
@app.post(
461469
"/apps/{app_name}/eval_sets/{eval_set_id}",
462470
response_model_exclude_none=True,
@@ -606,7 +614,9 @@ async def update_eval(
606614
"/apps/{app_name}/eval_sets/{eval_set_id}/evals/{eval_case_id}",
607615
tags=[TAG_EVALUATION],
608616
)
609-
async def delete_eval(app_name: str, eval_set_id: str, eval_case_id: str):
617+
async def delete_eval(
618+
app_name: str, eval_set_id: str, eval_case_id: str
619+
) -> None:
610620
try:
611621
self.eval_sets_manager.delete_eval_case(
612622
app_name, eval_set_id, eval_case_id
@@ -733,12 +743,6 @@ async def list_eval_metrics(app_name: str) -> list[MetricInfo]:
733743
status_code=400, detail=MISSING_EVAL_DEPENDENCIES_MESSAGE
734744
) from e
735745

736-
@app.delete("/apps/{app_name}/users/{user_id}/sessions/{session_id}")
737-
async def delete_session(app_name: str, user_id: str, session_id: str):
738-
await self.session_service.delete_session(
739-
app_name=app_name, user_id=user_id, session_id=session_id
740-
)
741-
742746
@app.get(
743747
"/apps/{app_name}/users/{user_id}/sessions/{session_id}/artifacts/{artifact_name}",
744748
response_model_exclude_none=True,
@@ -813,7 +817,7 @@ async def list_artifact_versions(
813817
)
814818
async def delete_artifact(
815819
app_name: str, user_id: str, session_id: str, artifact_name: str
816-
):
820+
) -> None:
817821
await self.artifact_service.delete_artifact(
818822
app_name=app_name,
819823
user_id=user_id,

0 commit comments

Comments
 (0)