Skip to content

Commit e0c0c56

Browse files
authored
Merge pull request #1826 from bruvzg/sync_android_vers
Sync Android SDK and NDK versions with the engine.
2 parents e53489b + 8646cd3 commit e0c0c56

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

.github/actions/setup-godot-cpp/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ inputs:
2020
default: 12.2.0
2121
description: MinGW version.
2222
ndk-version:
23-
default: r23c
23+
default: r28b
2424
description: Android NDK version.
2525
buildtool:
2626
default: scons

.github/workflows/ci-cmake.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ jobs:
7373
platform: android
7474
config-flags:
7575
-G Ninja -DCMAKE_BUILD_TYPE=Release
76-
--toolchain ${ANDROID_HOME}/ndk/23.2.8568313/build/cmake/android.toolchain.cmake
77-
-DANDROID_PLATFORM=21 -DANDROID_ABI=arm64-v8a
76+
--toolchain ${ANDROID_HOME}/ndk/28.1.13356709/build/cmake/android.toolchain.cmake
77+
-DANDROID_PLATFORM=24 -DANDROID_ABI=arm64-v8a
7878
artifact-name: godot-cpp-android-arm64-release.cmake
7979
artifact-path: cmake-build/bin/libgodot-cpp.android.template_release.arm64.a
8080
flags: arch=arm64

cmake/android.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function(android_options)
3434
more information
3535
3636
android_api_level : Target Android API level.
37-
Default = 21
37+
Default = 24
3838
3939
ANDROID_HOME : Path to your Android SDK installation.
4040
Default = os.environ.get("ANDROID_HOME", os.environ.get("ANDROID_SDK_ROOT")

doc/cmake.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ own toolchain file as listed in the cmake-toolchains_ documentation
253253

254254
Or use the toolchain and scripts provided by the Android SDK and make changes
255255
using the ``ANDROID_*`` variables listed there. Where ``<version>`` is whatever
256-
ndk version you have installed (tested with `23.2.8568313`) and ``<platform>``
256+
ndk version you have installed (tested with `28.1.13356709`) and ``<platform>``
257257
is for android sdk platform, (tested with ``android-29``)
258258

259259
.. warning::

tools/android.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ def options(opts):
99
opts.Add(
1010
"android_api_level",
1111
"Target Android API level",
12-
"21",
12+
"24",
1313
)
1414
opts.Add(
1515
"ndk_version",
1616
"Fully qualified version of ndk to use for compilation.",
17-
"23.2.8568313",
17+
"28.1.13356709",
1818
)
1919
opts.Add(
2020
"ANDROID_HOME",
@@ -48,9 +48,9 @@ def generate(env):
4848
my_spawn.configure(env)
4949

5050
# Validate API level
51-
if int(env["android_api_level"]) < 21:
52-
print("WARNING: minimum supported Android target api is 21. Forcing target api 21.")
53-
env["android_api_level"] = "21"
51+
if int(env["android_api_level"]) < 24:
52+
print("WARNING: minimum supported Android target api is 24. Forcing target api 24.")
53+
env["android_api_level"] = "24"
5454

5555
# Setup toolchain
5656
toolchain = get_android_ndk_root(env) + "/toolchains/llvm/prebuilt/"

0 commit comments

Comments
 (0)