Use sync.Map approach: no behavoir changes, memorizing the existing function

Author: paulquerna-okta

db.go

@@ -93,6 +93,13 @@ type DbMap struct {
 	tablesDynamic map[string]*TableMap // tables that use same go-struct and different db table names
 	logger        GorpLogger
 	logPrefix     string
+
+	Cache Cache
+}
+
+type Cache interface {
+	Load(key interface{}) (value interface{}, ok bool)
+	Store(key, value interface{})
 }
 
 func (m *DbMap) dynamicTableAdd(tableName string, tbl *TableMap) {

gorp.go

@@ -256,7 +256,32 @@ func expandNamedQuery(m *DbMap, query string, keyGetter func(key string) reflect
 	}), args
 }
 
+type fieldCacheKey struct {
+	t    reflect.Type
+	name string
+	cols string
+}
+
+type fieldCacheEntry struct {
+	mapping [][]int
+	err     error
+}
+
 func columnToFieldIndex(m *DbMap, t reflect.Type, name string, cols []string) ([][]int, error) {
+	var ck fieldCacheKey
+	var err error
+	if m.Cache != nil {
+		ck.t = t
+		ck.name = name
+		ck.cols = strings.Join(cols, ",")
+
+		rv, ok := m.Cache.Load(ck)
+		if ok {
+			entry := rv.(*fieldCacheEntry)
+			return entry.mapping, entry.err
+		}
+	}
+
 	colToFieldIndex := make([][]int, len(cols))
 
 	// check if type t is a mapped table - if so we'll
@@ -298,13 +323,22 @@ func columnToFieldIndex(m *DbMap, t reflect.Type, name string, cols []string) ([
 			missingColNames = append(missingColNames, colName)
 		}
 	}
+
 	if len(missingColNames) > 0 {
-		return colToFieldIndex, &NoFieldInTypeError{
+		err = &NoFieldInTypeError{
 			TypeName:        t.Name(),
 			MissingColNames: missingColNames,
 		}
 	}
-	return colToFieldIndex, nil
+
+	if m.Cache != nil {
+		entry := &fieldCacheEntry{
+			mapping: colToFieldIndex,
+			err:     err,
+		}
+		m.Cache.Store(ck, entry)
+	}
+	return colToFieldIndex, err
 }
 
 func fieldByName(val reflect.Value, fieldName string) *reflect.Value {

mapping_test.go

@@ -2,6 +2,7 @@ package gorp
 
 import (
 	"reflect"
+	"sync"
 	"testing"
 	"time"
 )
@@ -23,7 +24,7 @@ type testCoolUser struct {
 
 func BenchmarkCcolumnToFieldIndex(b *testing.B) {
 	structType := reflect.TypeOf(testUser{})
-	dbmap := &DbMap{}
+	dbmap := &DbMap{Cache: &sync.Map{}}
 	b.ResetTimer()
 	for n := 0; n < b.N; n++ {
 		_, err := columnToFieldIndex(dbmap,