Skip to content

Commit 8483d03

Browse files
committed
rename
1 parent 47ea426 commit 8483d03

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

modules/packages/hashed_buffer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func NewHashedBuffer() (*HashedBuffer, error) {
3535

3636
// NewHashedBufferWithSize creates a hashed buffer with a specific memory size
3737
func NewHashedBufferWithSize(maxMemorySize int) (*HashedBuffer, error) {
38-
tempDir, err := setting.AppDataTempDir("package-hashed-buffer").Mkdir("")
38+
tempDir, err := setting.AppDataTempDir("package-hashed-buffer").MkdirAllSub("")
3939
if err != nil {
4040
return nil, err
4141
}

modules/setting/packages.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func loadPackagesFrom(rootCfg ConfigProvider) (err error) {
6666
}
6767

6868
if HasInstallLock(rootCfg) {
69-
Packages.ChunkedUploadPath, err = AppDataTempDir("package-upload").Mkdir("")
69+
Packages.ChunkedUploadPath, err = AppDataTempDir("package-upload").MkdirAllSub("")
7070
if err != nil {
7171
return fmt.Errorf("unable to create chunked upload directory: %w", err)
7272
}

modules/tempdir/tempdir.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,17 @@ import (
1212
)
1313

1414
type TempDir struct {
15+
// base is the base directory for temporary files, it must exist before accessing and won't be created automatically.
16+
// for example: base="/system-tmpdir", sub="gitea-tmp"
1517
base, sub string
1618
}
1719

1820
func (td *TempDir) JoinPath(elems ...string) string {
1921
return filepath.Join(append([]string{td.base, td.sub}, elems...)...)
2022
}
2123

22-
func (td *TempDir) Mkdir(dir string) (string, error) {
24+
// MkdirAllSub works like os.MkdirAll, but the base directory must exist
25+
func (td *TempDir) MkdirAllSub(dir string) (string, error) {
2326
if _, err := os.Stat(td.base); err != nil {
2427
return "", err
2528
}
@@ -41,6 +44,7 @@ func (td *TempDir) prepareDirWithPattern(elems ...string) (dir, pattern string,
4144
return dir, pattern, nil
4245
}
4346

47+
// MkdirTempRandom works like os.MkdirTemp, the last path field is the "pattern"
4448
func (td *TempDir) MkdirTempRandom(elems ...string) (string, func(), error) {
4549
dir, pattern, err := td.prepareDirWithPattern(elems...)
4650
if err != nil {
@@ -57,6 +61,7 @@ func (td *TempDir) MkdirTempRandom(elems ...string) (string, func(), error) {
5761
}, nil
5862
}
5963

64+
// CreateTempFileRandom works like os.CreateTemp, the last path field is the "pattern"
6065
func (td *TempDir) CreateTempFileRandom(elems ...string) (*os.File, func(), error) {
6166
dir, pattern, err := td.prepareDirWithPattern(elems...)
6267
if err != nil {

0 commit comments

Comments
 (0)