Address copilot feedback

Author: ggilder

go/logic/throttler.go

@@ -504,6 +504,8 @@ func (thlr *Throttler) initiateThrottlerChecks() {
 // throttle sees if throttling needs take place, and if so, continuously sleeps (blocks)
 // until throttling reasons are gone
 func (thlr *Throttler) throttle(onThrottled func()) {
+	timer := time.NewTimer(250 * time.Millisecond)
+	defer timer.Stop()
 	for {
 		// IsThrottled() is non-blocking; the throttling decision making takes place asynchronously.
 		// Therefore calling IsThrottled() is cheap
@@ -513,10 +515,11 @@ func (thlr *Throttler) throttle(onThrottled func()) {
 		if onThrottled != nil {
 			onThrottled()
 		}
+		timer.Reset(250 * time.Millisecond)
 		select {
 		case <-thlr.migrationContext.GetContext().Done():
 			return
-		case <-time.After(250 * time.Millisecond):
+		case <-timer.C:
 		}
 	}
 }

go/logic/throttler_test.go

@@ -91,13 +91,20 @@ func TestThrottleCallsOnThrottledCallback(t *testing.T) {
 	thlr.migrationContext.SetThrottled(true, "test", base.NoThrottleReasonHint)
 
 	var callCount atomic.Int32
+	done := make(chan struct{})
 	go func() {
 		thlr.throttle(func() { callCount.Add(1) })
+		close(done)
 	}()
 
 	// wait long enough for at least two callback invocations
 	time.Sleep(700 * time.Millisecond)
 	assert.GreaterOrEqual(t, callCount.Load(), int32(2))
 
 	thlr.migrationContext.CancelContext()
+	select {
+	case <-done:
+	case <-time.After(1 * time.Second):
+		t.Fatal("throttle() did not return after context cancellation")
+	}
 }