Commit 87c2812
authored
Align
Compliance review found a mismatch between stated policy intent and
implementation for `list_repository_collaborators`: the PR rationale
specified reader integrity, but the guard assigned writer integrity.
This change resolves that discrepancy in code and tests so the tool’s
label semantics match the documented access-sensitive intent.
- **Policy alignment**
- Updated `list_repository_collaborators` in `tool_rules.rs` to assign
`reader_integrity(repo_id, ctx)` instead of `writer_integrity(repo_id,
ctx)`.
- Kept secrecy handling as private policy scope for
collaborator/permission metadata.
- **Documentation-in-code clarification**
- Updated the inline integrity comment from writer-level to reader-level
to reflect the intended trust boundary for access-sensitive collaborator
data.
- **Unit expectation update**
- Adjusted the dedicated test assertion to expect reader-level integrity
and updated the assertion message accordingly.
```rust
"list_repository_collaborators" => {
// S = private policy scope
// I = reader (access-sensitive metadata should not directly authorize writes)
secrecy = policy_private_scope_label(&owner, &repo, repo_id, ctx);
integrity = reader_integrity(repo_id, ctx);
}
```list_repository_collaborators DIFC integrity to reader-level (#5843)1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
391 | | - | |
| 391 | + | |
392 | 392 | | |
393 | | - | |
| 393 | + | |
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
| |||
939 | 939 | | |
940 | 940 | | |
941 | 941 | | |
942 | | - | |
| 942 | + | |
943 | 943 | | |
944 | 944 | | |
945 | 945 | | |
946 | | - | |
| 946 | + | |
947 | 947 | | |
948 | 948 | | |
949 | 949 | | |
0 commit comments