From a8e2a0b10b917a7166111a812ed9d4e86c55e676 Mon Sep 17 00:00:00 2001 From: Scott Rohde Date: Fri, 23 Oct 2020 13:44:19 -0500 Subject: [PATCH 1/2] Update managing-complex-workflows.md Environment variable names are apparently case-sensitive since without this change, the `example-command` (I tried it with `echo`) is fed the empty string. (On the other hand, environment variable names are case-_insensitive_ in one respect: Trying to define two environment variables whose names differ only in case yields a "duplicate definition" error.) --- .../actions/learn-github-actions/managing-complex-workflows.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/actions/learn-github-actions/managing-complex-workflows.md b/content/actions/learn-github-actions/managing-complex-workflows.md index 38e7e68e94cd..e7d9da43553a 100644 --- a/content/actions/learn-github-actions/managing-complex-workflows.md +++ b/content/actions/learn-github-actions/managing-complex-workflows.md @@ -29,7 +29,7 @@ jobs: env: super_secret: ${{ secrets.SUPERSECRET }} run: | - example-command "$SUPER_SECRET" + example-command "$super_secret" ``` {% endraw %} From 9c9e2dcb5d6ba98a601db0c4d1a935d6fb88f558 Mon Sep 17 00:00:00 2001 From: Lucas Costi Date: Wed, 4 Nov 2020 15:52:53 +1000 Subject: [PATCH 2/2] Add runs-on key to the example --- .../actions/learn-github-actions/managing-complex-workflows.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/actions/learn-github-actions/managing-complex-workflows.md b/content/actions/learn-github-actions/managing-complex-workflows.md index e7d9da43553a..3c4f0825784a 100644 --- a/content/actions/learn-github-actions/managing-complex-workflows.md +++ b/content/actions/learn-github-actions/managing-complex-workflows.md @@ -24,6 +24,7 @@ This example action demonstrates how to reference an existing secret as an envir ```yaml jobs: example-job: + runs-on: ubuntu-latest steps: - name: Retrieve secret env: