Skip to content

Update viewing-people-in-your-enterprise.md #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2021

Conversation

mirlenbrink
Copy link
Contributor

@mirlenbrink mirlenbrink commented Feb 26, 2021

Clean-up of spacing and grammar in the 'Viewing members and outside collaborators' section needed.

For GitHub.com version it previously rendered as below. Note the incorrect spacing before ",role , andorganization" in the second sentence.

You can view the number of pending members and outside collaborators. You can filter the list of members by deployment (GitHub Enterprise Cloud or GitHub Enterprise Server),role , andorganization. You can filter the list of outside collaborators by the visibility of the repositories the collaborator has access to. You can find a specific person by searching for their username or display name.

For GitHub.com Server versions it previously rendered as below. Note the lack of separation between "role organization" in the second sentence.

You can view the number of pending members and outside collaborators. You can filter the list of members by role organization. You can filter the list of outside collaborators by the visibility of the repositories the collaborator has access to. You can find a specific person by searching for their username or display name.

Why:

Closes #4044

What's being changed:

Updated the 'Viewing members and outside collaborators' section of the viewing-people-in-your-enterprise.md file.

Check off the following:

##Clean-up of spacing and grammar in the 'Viewing members and outside collaborators' section.

# For GitHub.com version it previously rendered as below.  Note the incorrect spacing before ",role , andorganization" in the second sentence.

You can view the number of pending members and outside collaborators. You can filter the list of members by deployment (GitHub Enterprise Cloud or GitHub Enterprise Server),role , andorganization. You can filter the list of outside collaborators by the visibility of the repositories the collaborator has access to. You can find a specific person by searching for their username or display name.

# For GitHub.com Server versions it rendered as below.  Note the lack of separation between "role organization" in the second sentence.

You can view the number of pending members and outside collaborators. You can filter the list of members by role organization. You can filter the list of outside collaborators by the visibility of the repositories the collaborator has access to. You can find a specific person by searching for their username or display name.
@welcome
Copy link

welcome bot commented Feb 26, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@mirlenbrink Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Mar 1, 2021
@shati-patel shati-patel self-assigned this Mar 3, 2021
shati-patel
shati-patel previously approved these changes Mar 3, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix, @mirlenbrink! 🎉

@shati-patel shati-patel enabled auto-merge (squash) March 3, 2021 16:54
@shati-patel shati-patel added the ready to merge This pull request is ready to merge label Mar 3, 2021
@shati-patel shati-patel merged commit 256ff7f into github:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean-up of spacing and grammar in the 'Viewing members and outside collaborators' section needed
3 participants