Skip to content

Correct page to post in Intro Docs #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Conversation

chrisdawww
Copy link
Contributor

Why:

#1684 : Github Pages intro docs typo fix

What's being changed:

There is a typo in the proposed markdown for teaching users how to add a new post to their site. The layout yaml front matter should be post not page.

Here's a link to the typo. It's in the YAML code block.

Check off the following:

NOTE: Do I need to check off the following for a single line typo fix??

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

There is a typo in the proposed markdown for teaching users how to add a new post to their site. The `layout` yaml front matter should be `post` not `page`
Here's a link to the typo https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/adding-content-to-your-github-pages-site-using-jekyll#adding-a-new-post-to-your-site
@welcome
Copy link

welcome bot commented Nov 29, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@chrisdawww Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 1, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdawww - Many thanks for fixing this. 👍
Much appreciated! 👏

@hubwriter hubwriter merged commit 872e402 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants