From 6d721e1d93d386af2bd7948f72a12b04e66fb137 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Fri, 20 Nov 2020 11:42:44 -0500 Subject: [PATCH 1/2] fix: Links to localhost addresses Put them in code blocks and stop ignoring them from link checking --- content/developers/apps/authorizing-oauth-apps.md | 2 +- content/developers/apps/using-content-attachments.md | 2 +- lib/excluded-links.js | 4 ---- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/content/developers/apps/authorizing-oauth-apps.md b/content/developers/apps/authorizing-oauth-apps.md index 655d7d41b8de..31d17ca636aa 100644 --- a/content/developers/apps/authorizing-oauth-apps.md +++ b/content/developers/apps/authorizing-oauth-apps.md @@ -272,7 +272,7 @@ The optional `redirect_uri` parameter can also be used for localhost URLs. If th For the `http://localhost/path` callback URL, you can use this `redirect_uri`: - http://localhost:1234/path + http://localhost:1234/path ### Creating multiple tokens for OAuth Apps diff --git a/content/developers/apps/using-content-attachments.md b/content/developers/apps/using-content-attachments.md index 035324a0db8e..3bbe27bf11f4 100644 --- a/content/developers/apps/using-content-attachments.md +++ b/content/developers/apps/using-content-attachments.md @@ -166,7 +166,7 @@ To create a Probot App, follow these steps: } ``` -4. [Run the GitHub App locally](https://probot.github.io/docs/development/#running-the-app-locally). Navigate to [localhost:3000](http://localhost:3000), and click the **Register GitHub App** button: +4. [Run the GitHub App locally](https://probot.github.io/docs/development/#running-the-app-locally). Navigate to `http://localhost:3000`, and click the **Register GitHub App** button: ![Register a Probot GitHub App](/assets/images/github-apps/github_apps_probot-registration.png) diff --git a/lib/excluded-links.js b/lib/excluded-links.js index 8339a4a01f69..c80aaacdcb43 100644 --- a/lib/excluded-links.js +++ b/lib/excluded-links.js @@ -9,10 +9,6 @@ module.exports = [ 'https://github.com/github/docs/edit', 'https://github.com/github/insights-releases/releases/latest', - // Developer content uses these for examples; they should not be checked. - 'http://localhost:1234', - 'localhost:3000', - // Oneoff links that link checkers think are broken but are not. 'https://haveibeenpwned.com/', 'https://www.ilo.org/dyn/normlex/en/f\\?p=NORMLEXPUB:12100:0::NO::P12100_ILO_CODE:P029', From 5ac23e1685fa662fca7cc6b709a744ab16c038ea Mon Sep 17 00:00:00 2001 From: Lucas Costi Date: Tue, 15 Dec 2020 16:27:46 +1000 Subject: [PATCH 2/2] Update content/developers/apps/authorizing-oauth-apps.md --- content/developers/apps/authorizing-oauth-apps.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/developers/apps/authorizing-oauth-apps.md b/content/developers/apps/authorizing-oauth-apps.md index 31d17ca636aa..dfb788811203 100644 --- a/content/developers/apps/authorizing-oauth-apps.md +++ b/content/developers/apps/authorizing-oauth-apps.md @@ -272,7 +272,9 @@ The optional `redirect_uri` parameter can also be used for localhost URLs. If th For the `http://localhost/path` callback URL, you can use this `redirect_uri`: - http://localhost:1234/path +``` +http://localhost:1234/path +``` ### Creating multiple tokens for OAuth Apps