Skip to content

Commit 8940279

Browse files
authored
Remove Google Analytics (#16158)
1 parent a18dc57 commit 8940279

File tree

4 files changed

+5
-45
lines changed

4 files changed

+5
-45
lines changed

javascripts/google-analytics.js

Lines changed: 0 additions & 13 deletions
This file was deleted.

javascripts/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import explorer from './explorer'
55
import search from './search'
66
import nav from './nav'
77
import browserDateFormatter from 'browser-date-formatter'
8-
import googleAnalytics from './google-analytics'
98
import deprecationBanner from './deprecation-banner'
109
import sidebar from './sidebar'
1110
import wrapCodeTerms from './wrap-code-terms'
@@ -23,7 +22,6 @@ document.addEventListener('DOMContentLoaded', async () => {
2322
search()
2423
nav()
2524
browserDateFormatter()
26-
googleAnalytics()
2725
deprecationBanner()
2826
sidebar()
2927
wrapCodeTerms()

javascripts/print.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { sendEvent } from './events'
2+
13
export default function () {
24
const printButton = document.querySelector('.js-print')
35

@@ -10,11 +12,6 @@ export default function () {
1012

1113
// Track print events
1214
window.onbeforeprint = function () {
13-
// Ensure that Google Analytics was registered
14-
if (!window.ga) return
15-
const category = 'Print'
16-
const action = 'print'
17-
const label = 'print'
18-
window.ga('send', 'event', category, action, label)
15+
sendEvent({ type: 'print' })
1916
}
2017
}

tests/browser/browser.js

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -92,28 +92,6 @@ describe('algolia browser search', () => {
9292
})
9393
})
9494

95-
describe('google analytics', () => {
96-
it('is set on page load with expected properties', async () => {
97-
await page.goto('http://localhost:4001/en/actions')
98-
99-
// check that GA global object exists and is a function
100-
const gaObjectType = await page.evaluate(() => typeof window.ga)
101-
expect(gaObjectType).toBe('function')
102-
103-
// check that default tracker is set
104-
// https://developers.google.com/analytics/devguides/collection/analyticsjs/ga-object-methods-reference#getByName
105-
const gaDefaultTracker = await page.evaluate(() => window.ga.getByName('t0'))
106-
expect('filters' in gaDefaultTracker).toBe(true)
107-
expect(Object.keys(gaDefaultTracker)).toHaveLength(3)
108-
109-
// check that default cookies are set
110-
// https://developers.google.com/analytics/devguides/collection/analyticsjs/cookie-usage#analyticsjs
111-
const cookies = await page.cookies()
112-
expect(cookies.some(cookie => cookie.name === '_gat')).toBe(true)
113-
expect(cookies.some(cookie => cookie.name === '_gid')).toBe(true)
114-
})
115-
})
116-
11795
describe('helpfulness', () => {
11896
it('sends an event to /events when submitting form', async () => {
11997
// Visit a page that displays the prompt
@@ -122,8 +100,8 @@ describe('helpfulness', () => {
122100
// Track network requests
123101
await page.setRequestInterception(true)
124102
page.on('request', request => {
125-
// Ignore GET to google analytics
126-
if (!/\/events/.test(request.method())) return request.continue()
103+
// Ignore GET requests
104+
if (!/\/events$/.test(request.url())) return request.continue()
127105
expect(request.method()).toMatch(/POST|PUT/)
128106
request.respond({
129107
contentType: 'application/json',

0 commit comments

Comments
 (0)