Merge pull request #3572 from github/mbg/pr-checks/eslint

Add eslint for `pr-checks`

Author: mbg

.github/workflows/pr-checks.yml

@@ -92,14 +92,17 @@ jobs:
           node-version: 24
           cache: 'npm'
 
+      - name: Install dependencies
+        run: npm ci
+
       - name: Verify PR checks up to date
         if: always()
         run: .github/workflows/script/verify-pr-checks.sh
 
       - name: Run pr-checks tests
         if: always()
         working-directory: pr-checks
-        run: npm ci && npx tsx --test
+        run: npx tsx --test
 
   check-node-version:
     if: github.triggering_actor != 'dependabot[bot]'

.github/workflows/rebuild.yml

@@ -34,9 +34,6 @@ jobs:
         with:
           node-version: 24
           cache: 'npm'
-          cache-dependency-path: |
-            package-lock.json
-            pr-checks/package-lock.json
 
       - name: Remove label
         if: github.event_name == 'pull_request'
@@ -97,7 +94,7 @@ jobs:
         working-directory: pr-checks
         run: |
           npm ci
-          npx tsx sync_back.ts --verbose
+          npx tsx sync-back.ts --verbose
 
       - name: Generate workflows
         working-directory: pr-checks

eslint.config.mjs

@@ -23,7 +23,6 @@ export default [
       "ava.setup.mjs",
       "eslint.config.mjs",
       ".github/**/*",
-      "pr-checks/**/*",
     ],
   },
   // eslint recommended config
@@ -170,4 +169,29 @@ export default [
       "func-style": "off",
     },
   },
+  {
+    files: ["pr-checks/**/*.ts"],
+
+    languageOptions: {
+      parserOptions: {
+        // Use the correct `tsconfig.json` for `pr-checks`.
+        project: "./pr-checks/tsconfig.json",
+      },
+    },
+
+    rules: {
+      // The scripts in `pr-checks` are expected to output to the console.
+      "no-console": "off",
+
+      "@typescript-eslint/no-floating-promises": [
+        "error",
+        {
+          allowForKnownSafeCalls: [
+            // Avoid needing explicit `void` in front of `describe` calls in test files.
+            { from: "package", name: ["describe"], package: "node:test" },
+          ],
+        },
+      ],
+    },
+  },
 ];

package-lock.json

@@ -15,6 +15,9 @@
     "transpile": "tsc --build --verbose"
   },
   "license": "MIT",
+  "workspaces": [
+    "pr-checks"
+  ],
   "dependencies": {
     "@actions/artifact": "^5.0.3",
     "@actions/artifact-legacy": "npm:@actions/artifact@^1.1.2",