Skip to content

Commit 0d2a78f

Browse files
committed
C++: Handle codeql_action_cpp_build_mode_none feature flag
1 parent 467d7e6 commit 0d2a78f

File tree

6 files changed

+37
-20
lines changed

6 files changed

+37
-20
lines changed

lib/feature-flags.js

Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/feature-flags.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action.js

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/feature-flags.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ export interface FeatureEnablement {
5050
export enum Feature {
5151
ArtifactV4Upgrade = "artifact_v4_upgrade",
5252
CleanupTrapCaches = "cleanup_trap_caches",
53-
CppBuildModeNoneDisabled = "cpp_build_mode_none_disabled",
54-
CppBuildModeNoneEnabled = "cpp_build_mode_none",
53+
CppBuildModeNone = "cpp_build_mode_none",
5554
CppDependencyInstallation = "cpp_dependency_installation_enabled",
5655
DiffInformedQueries = "diff_informed_queries",
5756
DisableCsharpBuildless = "disable_csharp_buildless",
@@ -105,14 +104,9 @@ export const featureConfig: Record<
105104
envVar: "CODEQL_ACTION_CLEANUP_TRAP_CACHES",
106105
minimumVersion: undefined,
107106
},
108-
[Feature.CppBuildModeNoneDisabled]: {
107+
[Feature.CppBuildModeNone]: {
109108
defaultValue: false,
110-
envVar: "CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE_DISABLED",
111-
minimumVersion: undefined,
112-
},
113-
[Feature.CppBuildModeNoneEnabled]: {
114-
defaultValue: false,
115-
envVar: "CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE_ENABLED",
109+
envVar: "CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE",
116110
minimumVersion: undefined,
117111
},
118112
[Feature.CppDependencyInstallation]: {

src/init-action.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,20 @@ async function run() {
546546
}
547547
}
548548

549+
// Set CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE
550+
if (config.languages.includes(Language.cpp)) {
551+
const bmn_var = "CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE";
552+
if (process.env[bmn_var]) {
553+
logger.info("CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE is already set");
554+
} else if (await features.getValue(Feature.CppBuildModeNone, codeql)) {
555+
logger.info("Enabling C++ build-mode: none");
556+
core.exportVariable(bmn_var, "true");
557+
} else {
558+
logger.info("Disabling C++ build-mode: none");
559+
core.exportVariable(bmn_var, "false");
560+
}
561+
}
562+
549563
// For CLI versions <2.15.1, build tracing caused errors in MacOS ARM machines with
550564
// System Integrity Protection (SIP) disabled.
551565
if (

0 commit comments

Comments
 (0)