Improved support for Windows terminals

Command Prompt, PowerShell, MinGW

Author: mschenk42

command/report.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"os"
 	"regexp"
+	"strings"
 
 	"github.com/git-time-metric/gtm/report"
 	"github.com/git-time-metric/gtm/scm"
@@ -65,9 +66,14 @@ func (r ReportCmd) Run(args []string) int {
 		commits = append(commits, a)
 	}
 
-	// TODO: if running from within a MINGW console isatty does not work
+	// if running from within a MINGW console isatty detection does not work
 	// https://github.com/mintty/mintty/issues/482
-	if !isatty.IsTerminal(os.Stdin.Fd()) && len(commits) == 0 && *limit == 0 {
+	isMinGW := strings.HasPrefix(os.Getenv("MSYSTEM"), "MINGW")
+	if isMinGW && *limit == 0 && len(commits) == 0 {
+		fmt.Println("\nGTM does not fully support the MinGW console, defaulting to gtm report -n 1")
+		fmt.Println("To avoid this message, use gtm report -n option or directly provide SHA1s as arguments")
+	}
+	if !isMinGW && !isatty.IsTerminal(os.Stdin.Fd()) && len(commits) == 0 && *limit == 0 {
 		scanner := bufio.NewScanner(os.Stdin)
 		for scanner.Scan() {
 			if !sha1Regex.MatchString(scanner.Text()) {

project/project.go

@@ -8,13 +8,13 @@ import (
 	"log"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"text/template"
 	"time"
 
-	"golang.org/x/crypto/ssh/terminal"
-
 	"github.com/git-time-metric/gtm/scm"
+	isatty "github.com/mattn/go-isatty"
 )
 
 var (
@@ -112,7 +112,7 @@ func Initialize() (string, error) {
 	}
 
 	headerFormat := "%s"
-	if terminal.IsTerminal(int(os.Stdout.Fd())) {
+	if isatty.IsTerminal(os.Stdout.Fd()) && runtime.GOOS != "windows" {
 		headerFormat = "\x1b[1m%s\x1b[0m"
 	}
 
@@ -171,7 +171,7 @@ func Uninitialize() (string, error) {
 	}
 
 	headerFormat := "%s"
-	if terminal.IsTerminal(int(os.Stdout.Fd())) {
+	if isatty.IsTerminal(os.Stdout.Fd()) && runtime.GOOS != "windows" {
 		headerFormat = "\x1b[1m%s\x1b[0m"
 	}
 	b := new(bytes.Buffer)

report/report.go

@@ -3,12 +3,12 @@ package report
 import (
 	"bytes"
 	"os"
+	"runtime"
 	"text/template"
 
-	"golang.org/x/crypto/ssh/terminal"
-
 	"github.com/git-time-metric/gtm/note"
 	"github.com/git-time-metric/gtm/util"
+	isatty "github.com/mattn/go-isatty"
 )
 
 var funcMap = template.FuncMap{
@@ -89,7 +89,7 @@ func Commits(commits []string, totalOnly bool) (string, error) {
 		t = template.Must(template.New("Commits").Funcs(funcMap).Parse(commitsTpl))
 	}
 	headerFormat := "%s"
-	if terminal.IsTerminal(int(os.Stdout.Fd())) {
+	if isatty.IsTerminal(os.Stdout.Fd()) && runtime.GOOS != "windows" {
 		headerFormat = "\x1b[1m%s\x1b[0m"
 	}
 	err := t.Execute(