Skip to content

Commit 55ee13e

Browse files
authored
feat: disable Telemetry Buffer (#1149)
1 parent 34261f3 commit 55ee13e

File tree

2 files changed

+26
-24
lines changed

2 files changed

+26
-24
lines changed

client.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -380,9 +380,11 @@ func NewClient(options ClientOptions) (*Client, error) {
380380

381381
client.setupTransport()
382382

383-
if !options.DisableTelemetryBuffer {
384-
client.setupTelemetryBuffer()
385-
} else if options.EnableLogs {
383+
// noop Telemetry Buffers fow now
384+
// if !options.DisableTelemetryBuffer {
385+
// client.setupTelemetryBuffer()
386+
// } else
387+
if options.EnableLogs {
386388
client.batchLogger = NewBatchLogger(&client)
387389
client.batchLogger.Start()
388390
}
@@ -408,7 +410,7 @@ func (client *Client) setupTransport() {
408410
client.Transport = transport
409411
}
410412

411-
func (client *Client) setupTelemetryBuffer() {
413+
func (client *Client) setupTelemetryBuffer() { // nolint: unused
412414
if client.options.DisableTelemetryBuffer {
413415
return
414416
}

client_test.go

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,26 +1036,26 @@ func TestClientSetsUpTransport(t *testing.T) {
10361036
require.IsType(t, &noopTransport{}, client.Transport)
10371037
}
10381038

1039-
func TestClient_SetupTelemetryBuffer_WithDSN(t *testing.T) {
1040-
client, err := NewClient(ClientOptions{
1041-
Dsn: "https://public@localhost/1",
1042-
})
1043-
if err != nil {
1044-
t.Fatalf("unexpected error: %v", err)
1045-
}
1046-
1047-
if client.telemetryBuffer == nil {
1048-
t.Fatal("expected telemetryBuffer to be initialized")
1049-
}
1050-
1051-
if _, ok := client.Transport.(*internalAsyncTransportAdapter); !ok {
1052-
t.Fatalf("expected internalAsyncTransportAdapter, got %T", client.Transport)
1053-
}
1054-
1055-
if !client.telemetryBuffer.Add(NewEvent()) {
1056-
t.Fatal("expected Add to succeed with default buffers")
1057-
}
1058-
}
1039+
// func TestClient_SetupTelemetryBuffer_WithDSN(t *testing.T) {
1040+
// client, err := NewClient(ClientOptions{
1041+
// Dsn: "https://public@localhost/1",
1042+
// })
1043+
// if err != nil {
1044+
// t.Fatalf("unexpected error: %v", err)
1045+
// }
1046+
//
1047+
// if client.telemetryBuffer == nil {
1048+
// t.Fatal("expected telemetryBuffer to be initialized")
1049+
// }
1050+
//
1051+
// if _, ok := client.Transport.(*internalAsyncTransportAdapter); !ok {
1052+
// t.Fatalf("expected internalAsyncTransportAdapter, got %T", client.Transport)
1053+
// }
1054+
//
1055+
// if !client.telemetryBuffer.Add(NewEvent()) {
1056+
// t.Fatal("expected Add to succeed with default buffers")
1057+
// }
1058+
//}
10591059

10601060
func TestClient_SetupTelemetryBuffer_NoDSN(t *testing.T) {
10611061
var buf bytes.Buffer

0 commit comments

Comments
 (0)