Skip to content

Commit c393c32

Browse files
committed
apply review feedback
1 parent 089f340 commit c393c32

File tree

1 file changed

+5
-5
lines changed
  • docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation

1 file changed

+5
-5
lines changed

docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation/index.mdx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,11 @@ if (span) {
246246
}
247247
```
248248

249-
Prior to v8.39.0, you had to use `span.updateName('New Name')`, which had some limitations in `@sentry/node` and SDKs depending on it (e.g. `@sentry/nextjs`):
249+
Prior to v8.39.0, you had to use `span.updateName('New Name')`, which had some limitations in `@sentry/node` and SDKs depending on it (for example, `@sentry/nextjs`):
250250

251-
- Spans with `http.method` or `http.request.method` attributes would automatically have their name set to the method + the URL path
252-
- Spans with `db.system` attributes would automatically have their name set to the system + the statement
251+
- Spans with `http.method` or `http.request.method` attributes would automatically have their name set to the method + the URL path.
252+
- Spans with `db.system` attributes would automatically have their name set to the system + the statement.
253253

254-
Using `Sentry.updateSpanName()` instead of `span.updateName()` ensures that the name is updated correctly and no longer overwritten in these cases.
254+
Using `Sentry.updateSpanName()` ensures that the name is updated correctly and no longer overwritten in these cases.
255255

256-
In browser environments (if you use `@sentry/browser`, `@sentry/react`, etc), `span.updateName()` and `Sentry.updateSpanName()` are identical and you can use either of them.
256+
If you use `@sentry/browser`, `@sentry/react`, and so on in browser environments, `span.updateName()` and `Sentry.updateSpanName()` will function identically, so you can use either one of them.

0 commit comments

Comments
 (0)