Ensure async consistency

Author: buenaflor

flutter/lib/src/native/java/android_replay_recorder.dart

@@ -27,7 +27,7 @@ class AndroidReplayRecorder extends ScheduledScreenshotRecorder {
   @override
   Future<void> start() async {
     final spawningWorker = _AndroidNativeReplayWorker.spawn();
-    super.start();
+    await super.start();
     _worker = await spawningWorker;
   }
 

flutter/lib/src/native/java/sentry_native_java.dart

@@ -37,7 +37,7 @@ class SentryNativeJava extends SentryNativeChannel {
                 height: (call.arguments['height'] as num).toDouble(),
                 frameRate: call.arguments['frameRate'] as int);
 
-            _replayRecorder?.onConfigurationChanged(config);
+            await _replayRecorder?.onConfigurationChanged(config);
             break;
           case 'ReplayRecorder.stop':
             hub.configureScope((s) {

flutter/lib/src/replay/scheduled_recorder.dart

@@ -42,7 +42,7 @@ class ScheduledScreenshotRecorder extends ReplayScreenshotRecorder {
     _callback = callback;
   }
 
-  void start() async {
+  Future<void> start() async {
     assert(() {
       // The following fails if callback hasn't been provided
       // in the constructor nor set with a setter.
@@ -52,22 +52,23 @@ class ScheduledScreenshotRecorder extends ReplayScreenshotRecorder {
 
     options.log(SentryLevel.debug, "$logName: starting capture");
     _status = _Status.running;
-    _restartScheduler();
+    await _restartScheduler();
   }
 
-  void onConfigurationChanged(ScheduledScreenshotRecorderConfig config) async {
+  Future<void> onConfigurationChanged(
+      ScheduledScreenshotRecorderConfig config) async {
     super.config = config;
     options.log(SentryLevel.debug,
         "$logName: onConfigurationChanged (${config.width}x${config.height} @ ${config.frameRate} Hz).");
 
-    _restartScheduler();
+    await _restartScheduler();
   }
 
   Future<void> _stopScheduler() {
     return _scheduler?.stop() ?? Future.value();
   }
 
-  void _restartScheduler() async {
+  Future<void> _restartScheduler() async {
     await _stopScheduler();
 
     if (super.config == null) {
@@ -114,7 +115,7 @@ class ScheduledScreenshotRecorder extends ReplayScreenshotRecorder {
   Future<void> resume() async {
     if (_status == _Status.paused) {
       _status = _Status.running;
-      _restartScheduler();
+      await _restartScheduler();
       // _idleFrameFiller.resume();
     }
   }

flutter/test/replay/scheduled_recorder_test.dart

@@ -59,7 +59,7 @@ class _Fixture {
   static Future<_Fixture> create(WidgetTester tester) async {
     final fixture = _Fixture._(tester);
     await pumpTestElement(tester);
-    fixture.sut.start();
+    await fixture.sut.start();
     return fixture;
   }