[TASK] Improve test suite

Author: georgringer

.github/workflows/ci.yml

@@ -26,6 +26,20 @@ jobs:
           extensions: intl, mbstring
           coverage: none
 
+      - name: Get Composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache Composer packages
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.typo3 }}-${{ matrix.composerInstall }}-${{ hashFiles('composer.json') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.typo3 }}-${{ matrix.composerInstall }}-
+            ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.typo3 }}-
+            ${{ runner.os }}-composer-${{ matrix.php }}-
+
       - name: Pin TYPO3 version
         run: composer require --no-update "typo3/cms-core:${{ matrix.typo3 }}" "typo3/cms-redirects:${{ matrix.typo3 }}"
 

Tests/Unit/Command/ImportRedirectCommandTest.php

@@ -21,10 +21,10 @@ final class ImportRedirectCommandTest extends TestCase
     protected function setUp(): void
     {
         $this->subject = new ImportRedirectCommand(
-            $this->createMock(RedirectRepository::class),
-            $this->createMock(UrlMatcher::class),
-            $this->createMock(NotificationHandler::class),
-            $this->createMock(ExtensionConfiguration::class),
+            $this->createStub(RedirectRepository::class),
+            $this->createStub(UrlMatcher::class),
+            $this->createStub(NotificationHandler::class),
+            $this->createStub(ExtensionConfiguration::class),
         );
     }
 

Tests/Unit/Domain/Model/Dto/UrlResultTest.php

@@ -16,13 +16,13 @@ final class UrlResultTest extends TestCase
     #[Test]
     public function getLinkStringForDefaultLanguageOmitsLParameter(): void
     {
-        $language = $this->createMock(SiteLanguage::class);
+        $language = $this->createStub(SiteLanguage::class);
         $language->method('getLanguageId')->willReturn(0);
 
-        $routeResult = $this->createMock(SiteRouteResult::class);
+        $routeResult = $this->createStub(SiteRouteResult::class);
         $routeResult->method('getLanguage')->willReturn($language);
 
-        $pageArguments = $this->createMock(PageArguments::class);
+        $pageArguments = $this->createStub(PageArguments::class);
         $pageArguments->method('getPageId')->willReturn(42);
 
         $result = new UrlResult($routeResult, $pageArguments);
@@ -33,13 +33,13 @@ public function getLinkStringForDefaultLanguageOmitsLParameter(): void
     #[Test]
     public function getLinkStringForNonDefaultLanguageIncludesLParameter(): void
     {
-        $language = $this->createMock(SiteLanguage::class);
+        $language = $this->createStub(SiteLanguage::class);
         $language->method('getLanguageId')->willReturn(2);
 
-        $routeResult = $this->createMock(SiteRouteResult::class);
+        $routeResult = $this->createStub(SiteRouteResult::class);
         $routeResult->method('getLanguage')->willReturn($language);
 
-        $pageArguments = $this->createMock(PageArguments::class);
+        $pageArguments = $this->createStub(PageArguments::class);
         $pageArguments->method('getPageId')->willReturn(5);
 
         $result = new UrlResult($routeResult, $pageArguments);
@@ -50,10 +50,10 @@ public function getLinkStringForNonDefaultLanguageIncludesLParameter(): void
     #[Test]
     public function getLinkStringWithNullLanguageOmitsLParameter(): void
     {
-        $routeResult = $this->createMock(SiteRouteResult::class);
+        $routeResult = $this->createStub(SiteRouteResult::class);
         $routeResult->method('getLanguage')->willReturn(null);
 
-        $pageArguments = $this->createMock(PageArguments::class);
+        $pageArguments = $this->createStub(PageArguments::class);
         $pageArguments->method('getPageId')->willReturn(1);
 
         $result = new UrlResult($routeResult, $pageArguments);
@@ -64,10 +64,10 @@ public function getLinkStringWithNullLanguageOmitsLParameter(): void
     #[Test]
     public function gettersReturnInjectedObjects(): void
     {
-        $routeResult = $this->createMock(SiteRouteResult::class);
+        $routeResult = $this->createStub(SiteRouteResult::class);
         $routeResult->method('getLanguage')->willReturn(null);
 
-        $pageArguments = $this->createMock(PageArguments::class);
+        $pageArguments = $this->createStub(PageArguments::class);
         $pageArguments->method('getPageId')->willReturn(1);
 
         $result = new UrlResult($routeResult, $pageArguments);