fix lazysprite multiple callback calls

Author: dankmeme01

loader/include/Geode/ui/LazySprite.hpp

@@ -50,11 +50,9 @@ namespace geode {
         bool isLoaded();
         bool isLoading();
 
-        virtual bool initWithTexture(cocos2d::CCTexture2D* texture) override;
         virtual bool initWithTexture(cocos2d::CCTexture2D* pTexture, const cocos2d::CCRect& rect) override;
         virtual bool initWithSpriteFrame(cocos2d::CCSpriteFrame* pSpriteFrame) override;
         virtual bool initWithSpriteFrameName(const char* pszSpriteFrameName) override;
-        virtual bool initWithFile(const char* pszFilename) override;
         virtual bool initWithFile(const char* pszFilename, const cocos2d::CCRect& rect) override;
 
     private:

loader/src/ui/nodes/LazySprite.cpp

@@ -298,8 +298,9 @@ void LazySprite::doInitFromBytes(std::vector<uint8_t> data, std::string cacheKey
 
             image->release();   // deallocate the image, not needed anymore
             texture->release(); // bring texture's refcount back to 1
-
-            if (!self->initWithTexture(texture)) {
+            
+            // this is weird but don't touch it unless you should
+            if (!self->CCSprite::initWithTexture(texture)) {
                 // this should never happen tbh
                 self->onError("failed to initialize the sprite");
             }
@@ -323,7 +324,7 @@ CCTexture2D* LazySprite::lookupCache(char const* key) {
 
 bool LazySprite::initFromCache(char const* key) {
     if (auto tex = this->lookupCache(key)) {
-        return this->initWithTexture(tex);
+        return CCSprite::initWithTexture(tex); // this will end up calling our overriden 2-arg func, which is what we want
     }
 
     return false;
@@ -335,10 +336,6 @@ bool LazySprite::initWithTexture(CCTexture2D* texture, const CCRect& rect) {
     return this->postInit(CCSprite::initWithTexture(texture, rect));
 }
 
-bool LazySprite::initWithTexture(CCTexture2D* texture) {
-    return this->postInit(CCSprite::initWithTexture(texture));
-}
-
 bool LazySprite::initWithSpriteFrame(CCSpriteFrame* sf) {
     return this->postInit(CCSprite::initWithSpriteFrame(sf));
 }
@@ -347,10 +344,6 @@ bool LazySprite::initWithSpriteFrameName(const char* fn) {
     return this->postInit(CCSprite::initWithSpriteFrameName(fn));
 }
 
-bool LazySprite::initWithFile(const char* fn) {
-    return this->postInit(CCSprite::initWithFile(fn));
-}
-
 bool LazySprite::initWithFile(const char* fn, const CCRect& rect) {
     return this->postInit(CCSprite::initWithFile(fn, rect));
 }