Small fixes

Author: gansm

.github/scripts/get_code_cov.sh

@@ -14,6 +14,8 @@ run_gcov ()
   then
     gcov -lp -o "./.libs/" "$FILENAME"
   fi
+
+  return 0
 }
 
 find "./test/" \

build.sh

@@ -16,13 +16,13 @@ cd "$SRCDIR" || exit
 print_systeminfo ()
 {
   test -z "$CXX" && eval "$(grep '^CXX = ' "Makefile" | cut -d' ' -f1-3 | sed -e 's/ //g')"
-  local CXX_VERSION="$($CXX -dumpfullversion -dumpversion || echo "unknown version")"
-  local BUILD_MODE="$1"
+  local cxx_version="$($CXX -dumpfullversion -dumpversion || echo "unknown version")"
+  local build_mode="$1"
   echo "-------------------------"
   echo "      Platform: $PLATFORM"
   echo "  Architecture: $ARCH"
-  echo "      Compiler: $CXX $CXX_VERSION"
-  echo "         Build: $BUILD_MODE"
+  echo "      Compiler: $CXX $cxx_version"
+  echo "         Build: $build_mode"
   echo "Number of jobs: $JOBS"
   echo "-------------------------"
   return 0
@@ -34,15 +34,16 @@ then
   CPU_COUNT="$(getconf _NPROCESSORS_ONLN 2>/dev/null || getconf NPROCESSORS_ONLN 2>/dev/null)" || CPU_COUNT="0"
 fi
 
-if [ "$CPU_COUNT" -eq 0 \
-  && command -v nproc >/dev/null 2>&1 ]
+if [ "$CPU_COUNT" -eq 0 ] \
+&& command -v nproc >/dev/null 2>&1
 then
   CPU_COUNT="$(nproc 2>/dev/null)" || CPU_COUNT="0"
 fi
 
 test "$CPU_COUNT" -eq 0 && CPU_COUNT=1
 
-if [ -n "$1" && ! -f ./configure ]
+if [ -n "$1" ] \
+&& [ ! -f ./configure ]
 then
   if command -v autoreconf >/dev/null
   then

examples/rotozoomer.cpp

@@ -50,7 +50,7 @@ using finalcut::FColor;
 namespace {
 
 // Constants
-static constexpr int MAX_LOOPS{314};
+constexpr int MAX_LOOPS{314};
 
 // Non-member functions
 constexpr auto generateSinTable() noexcept -> std::array<float, MAX_LOOPS>

final/output/tty/ftermoutput.cpp

@@ -49,8 +49,10 @@ namespace internal
 template <typename T>
 constexpr T clampValue (T value, T minVal, T maxVal)
 {
-  return ( value < minVal ) ? minVal :
-         ( value > maxVal ) ? maxVal : value;
+  if ( value < minVal )
+    return minVal;
+  else
+    return ( value > maxVal ) ? maxVal : value;
 }
 
 template <typename T>

final/vterm/fvterm.cpp

@@ -311,7 +311,7 @@ void FVTerm::putVTerm() const
   auto vterm_changes = &vterm->changes_in_line[unsigned(0)];
   std::for_each ( vterm_changes
                 , vterm_changes + unsigned(vterm->size.height)
-                , [this, &xmax] (auto& vterm_changes_line) noexcept
+                , [&xmax] (auto& vterm_changes_line) noexcept
                   {
                     vterm_changes_line.xmin = 0;
                     vterm_changes_line.xmax = xmax;

final/vterm/fvterm.h

@@ -469,7 +469,7 @@ struct FVTerm::FTermArea  // Define virtual terminal character properties
   constexpr auto isOverlapped (const FRect&) const noexcept -> bool;
   constexpr auto isOverlapped (const FTermArea*) const noexcept -> bool;
   constexpr auto isPrintPositionInsideArea() const noexcept -> bool;
-  inline auto reprint (const FRect&, const FSize&) noexcept -> bool;
+  auto reprint (const FRect&, const FSize&) noexcept -> bool;
 
   inline auto getFChar (int x, int y) const noexcept -> const FChar&
   {
@@ -512,7 +512,7 @@ struct FVTerm::FTermArea  // Define virtual terminal character properties
     return -1;
   }
 
-  inline void updateAreaChanges (uInt, uInt, uInt8) noexcept;
+  void updateAreaChanges (uInt, uInt, uInt8) noexcept;
 
   // Data members
   struct Coordinate

scripts/perf-call-graph.sh

@@ -14,15 +14,13 @@ then
   CPU_COUNT="$(getconf _NPROCESSORS_ONLN 2>/dev/null || getconf NPROCESSORS_ONLN 2>/dev/null)" || CPU_COUNT="0"
 fi
 
-if [ "$CPU_COUNT" -eq 0 ]
+if [[ "$CPU_COUNT" -eq 0 ]] \
+&& command -v nproc >/dev/null 2>&1
 then
-  if command -v nproc >/dev/null 2>&1
-  then
-    CPU_COUNT="$(nproc 2>/dev/null)" || CPU_COUNT="0"
-  fi
+  CPU_COUNT="$(nproc 2>/dev/null)" || CPU_COUNT="0"
 fi
 
-test "$CPU_COUNT" -eq 0 && CPU_COUNT=1
+[[ "$CPU_COUNT" -eq 0 ]] && CPU_COUNT=1
 
 SAVE_DIR="$PWD"
 cd .. || exit
@@ -33,7 +31,7 @@ cd "$SAVE_DIR"
 
 echo 0 > /proc/sys/kernel/kptr_restrict
 
-if [ $# -gt 0 ]
+if [[ $# -gt 0 ]]
 then
   LD_LIBRARY_PATH="../final/.libs/" perf record -g "$@"
 else