Skip to content

Commit bfef069

Browse files
authored
[Impeller] disabled misleading vulkan golden image tests (flutter#49836)
issue: flutter/flutter#141705 The MetalScreenshotter is hardcoded to make a Metal context. So even though the tests were running the Vulkan variant, the rendering was still happening with Metal. It's better to disable these for now until they can be implemented properly (either by making them render with swiftshader on mac or rendering them on linux). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 2f11b63 commit bfef069

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

impeller/golden_tests/golden_playground_test_mac.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ void GoldenPlaygroundTest::SetUp() {
122122
std::filesystem::path icd_path = target_path / "vk_swiftshader_icd.json";
123123
setenv("VK_ICD_FILENAMES", icd_path.c_str(), 1);
124124

125-
if (GetBackend() != PlaygroundBackend::kMetal &&
126-
GetBackend() != PlaygroundBackend::kVulkan) {
125+
if (GetBackend() != PlaygroundBackend::kMetal) {
127126
GTEST_SKIP_("GoldenPlaygroundTest doesn't support this backend type.");
128127
return;
129128
}

0 commit comments

Comments
 (0)