Skip to content

Commit 5879076

Browse files
committed
Fixed rendering issue with Download and Remove resources
1 parent aa2b227 commit 5879076

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

renderer/src/components/Resources/ListResources.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const ListResources = ({
6262
const [translationAcademy, setTranslationAcademy] = useState([]);
6363
const [obsTranslationNote, setObsTranslationNote] = useState([]);
6464
const [obsTranslationQuestion, setObsTranslationQuestion] = useState([]);
65-
65+
const [renderApp, setRenderApp] = useState(false);
6666
const handleDownloadHelpsResources = async (event, reference, offlineResource) => {
6767
if (!downloading) {
6868
try {
@@ -72,6 +72,7 @@ export const ListResources = ({
7272
setCurrentDownloading(null);
7373
setOpenSnackBar(true);
7474
setError('success');
75+
setRenderApp(true);
7576
setSnackText('Resource Download Finished');
7677
} catch (err) {
7778
logger.debug('ResourcesPopUp.js', 'Error Downlaod ', err);
@@ -138,7 +139,10 @@ export const ListResources = ({
138139

139140
useEffect(() => { // LOADS locally available
140141
readLocalResources(username, setSubMenuItems);
141-
}, []);
142+
if (renderApp === true) {
143+
setRenderApp(false);
144+
}
145+
}, [renderApp]);
142146

143147
return (
144148
<div className="h-full">
@@ -229,6 +233,7 @@ export const ListResources = ({
229233
<RemoveResource
230234
resource={resource}
231235
selectResource={selectResource}
236+
setRenderApp={setRenderApp}
232237
/>
233238
</div>
234239
</div>

renderer/src/components/Resources/ObsBibleAudioTab.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* eslint-disable react-hooks/exhaustive-deps */
22
/* eslint-disable no-nested-ternary */
33
/* eslint-disable jsx-a11y/control-has-associated-label */
4-
import React, { useContext, useEffect } from 'react';
4+
import React, { useContext, useEffect, useState } from 'react';
55
import { useTranslation } from 'react-i18next';
66
import RemoveResource from '@/components/Resources/ResourceUtils/RemoveResource';
77
import CheckHelpsUpdatePopUp from '@/components/Resources/ResourceUtils/CheckHelpsUpdatePopUp';
@@ -19,6 +19,7 @@ export default function ObsBibleAudioTab({
1919
subMenuItems,
2020
}) {
2121
const { t } = useTranslation();
22+
const [renderApp, setRenderApp] = useState(false);
2223
const {
2324
states: {
2425
username,
@@ -33,7 +34,10 @@ export default function ObsBibleAudioTab({
3334

3435
useEffect(() => { // LOADS locally available
3536
readLocalResources(username, setSubMenuItems);
36-
}, []);
37+
if (renderApp === true) {
38+
setRenderApp(false);
39+
}
40+
}, [renderApp]);
3741

3842
useEffect(() => {
3943
const resourceName = (selectResource === 'bible')
@@ -159,6 +163,7 @@ export default function ObsBibleAudioTab({
159163
<RemoveResource
160164
resource={ref}
161165
selectResource={selectResource}
166+
setRenderApp={setRenderApp}
162167
/>
163168
)}
164169
</div>

renderer/src/components/Resources/ResourceUtils/RemoveResource.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const ResourceResetAfterCheckSameOnRefResourceAgSettings = async (setResetResour
9090
};
9191

9292
function RemoveResource({
93-
resource, selectResource,
93+
resource, selectResource, setRenderApp,
9494
}) {
9595
logger.warn('removeResource.js', 'inside remove resource');
9696
const { t } = useTranslation();
@@ -148,6 +148,7 @@ function RemoveResource({
148148
// read ag-settings of the project
149149
await ResourceResetAfterCheckSameOnRefResourceAgSettings(setResetResourceOnDeleteOffline, resource);
150150
// handleRowSelect(null, null, null, null, '');
151+
setRenderApp(true);
151152
setOpenSnackBar(true);
152153
setNotify('success');
153154
setSnackText('Removed Resource Successfully');
@@ -193,6 +194,7 @@ function RemoveResource({
193194
RemoveResource.propTypes = {
194195
resource: PropTypes.object,
195196
selectResource: PropTypes.string,
197+
setRenderApp: PropTypes.func,
196198
};
197199

198200
export default RemoveResource;

0 commit comments

Comments
 (0)