@@ -199,12 +199,12 @@ public function saveOptions(array $data): array
199
199
}
200
200
201
201
try {
202
- $ s3Config ->setUseLegacyPathStyle (! empty ( $ data ['legacy ' ]) );
202
+ $ s3Config ->setUseLegacyPathStyle (( bool ) $ data ['legacy ' ] ?? false );
203
203
} catch (\Exception $ exception ) {
204
204
$ feedback ['legacy ' ] = $ exception ->getMessage ();
205
205
}
206
206
try {
207
- $ s3Config ->setUseDualstackUrl (! empty ( $ data ['dualstack_url ' ]) );
207
+ $ s3Config ->setUseDualstackUrl (( bool ) $ data ['dualstack_url ' ] ?? false );
208
208
} catch (\Exception $ exception ) {
209
209
$ feedback ['dualstack_url ' ] = $ exception ->getMessage ();
210
210
}
@@ -233,8 +233,16 @@ public function saveOptions(array $data): array
233
233
$ this ->config ->set ('s3 ' , 'secret_key ' , ($ this ->secretKey = new HiddenString ($ data ['secret_key ' ]))->getString ());
234
234
$ this ->config ->set ('s3 ' , 'bucket ' , ($ this ->bucket = $ bucket ));
235
235
236
- $ this ->config ->set ('s3 ' , 'legacy ' , $ s3Config ->getUseLegacyPathStyle ());
237
- $ this ->config ->set ('s3 ' , 'dual_stack ' , $ s3Config ->getUseLegacyPathStyle ());
236
+ if ($ s3Config ->getUseLegacyPathStyle ()) {
237
+ $ this ->config ->set ('s3 ' , 'legacy ' , '1 ' );
238
+ } else {
239
+ $ this ->config ->delete ('s3 ' , 'legacy ' );
240
+ }
241
+ if ($ s3Config ->getDualstackUrl ()) {
242
+ $ this ->config ->set ('s3 ' , 'dual_stack ' , '1 ' );
243
+ } else {
244
+ $ this ->config ->delete ('s3 ' , 'dual_stack ' );
245
+ }
238
246
$ this ->config ->set ('s3 ' ,'signature_method ' , $ s3Config ->getSignatureMethod ());
239
247
240
248
if (!empty ($ data ['endpoint ' ])) {
0 commit comments