Skip to content

Commit f97e3c8

Browse files
richardlaufoxxyz
authored andcommitted
build: make build-addons errors fail the build
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and then uses `touch` to update a timestamp file. Unconditionally calling `touch` was losing the exit code from `tools/doc/addon-verify.js` so any errors produced by that script were not failing the build. PR-URL: nodejs#38983 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent d5550e4 commit f97e3c8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ test/addons/.docbuildstamp: $(DOCBUILDSTAMP_PREREQS) tools/doc/node_modules
350350
else \
351351
$(RM) -r test/addons/??_*/; \
352352
[ -x $(NODE) ] && $(NODE) $< || node $< ; \
353-
touch $@; \
353+
[ $$? -eq 0 ] && touch $@; \
354354
fi
355355

356356
ADDONS_BINDING_GYPS := \

0 commit comments

Comments
 (0)