fix(ngModelAttrsManipulator): Remove deprecated code

You used to be able to specify  in your  property. Now it should
be defined in your  property.

BREAKING CHANGE: If you used  before and did not heed the deprecation
warning, you're going to want to move it to .

Author: Kent C. Dodds

other/ERRORS_AND_WARNINGS.md

@@ -127,32 +127,6 @@ of the expression, the scope you're passed wont have all the properties you may
 See documentation [here](http://docs.angular-formly.com/docs/field-configuration-object#hideexpression-string--function)
 and an example [here](http://angular-formly.com/#/example/field-options/hide-fields)
 
-# skipNgModelAttrsManipulator moved
-
-This property has been moved from the `data` property to the `extras` property.
-
-Before:
-
-```javascript
-{
-  template: '<hr />',
-  data: {
-    skipNgModelAttrsManipulator: true
-  }
-}
-```
-
-After:
-
-```javascript
-{
-  template: '<hr />',
-  extras: {
-    skipNgModelAttrsManipulator: true
-  }
-}
-```
-
 # Notes
 
 It is recommended to disable warnings in production using `formlyConfigProvider.disableWarnings = true`. Note: This will

src/run/formlyNgModelAttrsManipulator.js

@@ -4,7 +4,7 @@ import {contains} from '../other/utils';
 export default addFormlyNgModelAttrsManipulator;
 
 // @ngInject
-function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate, formlyWarn) {
+function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate) {
   if (formlyConfig.extras.disableNgModelAttrsManipulator) {
     return;
   }
@@ -13,7 +13,7 @@ function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate, formlyWarn
 
   function ngModelAttrsManipulator(template, options, scope) {
     const node = document.createElement('div');
-    const skip = getSkip(options);
+    const skip = options.extras && options.extras.skipNgModelAttrsManipulator;
     if (skip === true) {
       return template;
     }
@@ -172,22 +172,6 @@ function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate, formlyWarn
     return div.querySelector(selector);
   }
 
-  function getSkip(options) {
-    // UPDATE IN 7.0.0
-    let skip = options.extras && options.extras.skipNgModelAttrsManipulator;
-    if (!angular.isDefined(skip)) {
-      skip = options.data && options.data.skipNgModelAttrsManipulator;
-      if (angular.isDefined(skip)) {
-        formlyWarn(
-          'skipngmodelattrsmanipulator-moved',
-          'The skipNgModelAttrsManipulator property has been moved from the `data` property to the `extras` property',
-          options
-        );
-      }
-    }
-    return skip;
-  }
-
   function getBuiltInAttributes() {
     const ngModelAttributes = {
       focus: {

src/run/formlyNgModelAttrsManipulator.test.js

@@ -2,18 +2,13 @@
 import angular from 'angular';
 import _ from 'lodash';
 
-import testUtils from '../test.utils.js';
-
-const {shouldWarnWithLog} = testUtils;
-
 describe('formlyNgModelAttrsManipulator', () => {
   beforeEach(window.module('formly'));
 
-  let formlyConfig, manipulator, scope, field, result, resultEl, resultNode, $log;
+  let formlyConfig, manipulator, scope, field, result, resultEl, resultNode;
   const template = '<input ng-model="model[options.key]" />';
 
-  beforeEach(inject((_formlyConfig_, $rootScope, _$log_) => {
-    $log = _$log_;
+  beforeEach(inject((_formlyConfig_, $rootScope) => {
     formlyConfig = _formlyConfig_;
     manipulator = formlyConfig.templateManipulators.preWrapper[0];
     scope = $rootScope.$new();
@@ -27,17 +22,6 @@ describe('formlyNgModelAttrsManipulator', () => {
   }));
 
   describe(`skipping`, () => {
-    it(`should give a deprecation warning when using the data property`, () => {
-      field.data.skipNgModelAttrsManipulator = true;
-      const logArgs = [
-        'Formly Warning:',
-        'The skipNgModelAttrsManipulator property has been moved from the `data` property to the `extras` property',
-        field,
-        /skipngmodelattrsmanipulator-moved/
-      ];
-      shouldWarnWithLog($log, logArgs, manipulate);
-    });
-
 
     it(`should allow you to skip the manipulator wholesale for the field`, () => {
       field.extras.skipNgModelAttrsManipulator = true;