Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

Commit 56ecbf5

Browse files
committed
v8.2.1
2 parents 73c85fe + 64a8694 commit 56ecbf5

File tree

6 files changed

+75
-13
lines changed

6 files changed

+75
-13
lines changed

dist/formly.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* angular-formly JavaScript Library v8.2.0
2+
* angular-formly JavaScript Library v8.2.1
33
*
44
* @license MIT (http://license.angular-formly.com)
55
*
@@ -157,7 +157,7 @@ return /******/ (function(modules) { // webpackBootstrap
157157

158158
ngModule.constant('formlyApiCheck', _providersFormlyApiCheck2['default']);
159159
ngModule.constant('formlyErrorAndWarningsUrlPrefix', _otherDocsBaseUrl2['default']);
160-
ngModule.constant('formlyVersion', ("8.2.0")); // <-- webpack variable
160+
ngModule.constant('formlyVersion', ("8.2.1")); // <-- webpack variable
161161

162162
ngModule.provider('formlyUsability', _providersFormlyUsability2['default']);
163163
ngModule.provider('formlyConfig', _providersFormlyConfig2['default']);
@@ -435,7 +435,7 @@ return /******/ (function(modules) { // webpackBootstrap
435435
Object.defineProperty(exports, "__esModule", {
436436
value: true
437437
});
438-
exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("8.2.0") + "/other/ERRORS_AND_WARNINGS.md#";
438+
exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("8.2.1") + "/other/ERRORS_AND_WARNINGS.md#";
439439
module.exports = exports["default"];
440440

441441
/***/ },
@@ -668,7 +668,7 @@ return /******/ (function(modules) { // webpackBootstrap
668668
if (!_angularFix2['default'].isDefined(extendsDO)) {
669669
return;
670670
}
671-
var optionsDO = options.defaultOptions;
671+
var optionsDO = options.defaultOptions || {};
672672
var optionsDOIsFn = _angularFix2['default'].isFunction(optionsDO);
673673
var extendsDOIsFn = _angularFix2['default'].isFunction(extendsDO);
674674
if (extendsDOIsFn) {
@@ -680,8 +680,8 @@ return /******/ (function(modules) { // webpackBootstrap
680680
if (optionsDOIsFn) {
681681
extenderOptionsDefaultOptions = extenderOptionsDefaultOptions(mergedDefaultOptions, scope);
682682
}
683-
_otherUtils2['default'].reverseDeepMerge(extendsDefaultOptions, extenderOptionsDefaultOptions);
684-
return extendsDefaultOptions;
683+
_otherUtils2['default'].reverseDeepMerge(extenderOptionsDefaultOptions, extendsDefaultOptions);
684+
return extenderOptionsDefaultOptions;
685685
};
686686
} else if (optionsDOIsFn) {
687687
options.defaultOptions = function defaultOptions(opts, scope) {

dist/formly.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/formly.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-formly",
3-
"version": "8.2.0",
3+
"version": "8.2.1",
44
"author": "Astrism <[email protected]>",
55
"contributors": [
66
"Astrism <[email protected]>",

src/providers/formlyConfig.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ function formlyConfig(formlyUsabilityProvider, formlyErrorAndWarningsUrlPrefix,
124124
if (!angular.isDefined(extendsDO)) {
125125
return
126126
}
127-
const optionsDO = options.defaultOptions
127+
const optionsDO = options.defaultOptions || {}
128128
const optionsDOIsFn = angular.isFunction(optionsDO)
129129
const extendsDOIsFn = angular.isFunction(extendsDO)
130130
if (extendsDOIsFn) {
@@ -136,8 +136,8 @@ function formlyConfig(formlyUsabilityProvider, formlyErrorAndWarningsUrlPrefix,
136136
if (optionsDOIsFn) {
137137
extenderOptionsDefaultOptions = extenderOptionsDefaultOptions(mergedDefaultOptions, scope)
138138
}
139-
utils.reverseDeepMerge(extendsDefaultOptions, extenderOptionsDefaultOptions)
140-
return extendsDefaultOptions
139+
utils.reverseDeepMerge(extenderOptionsDefaultOptions, extendsDefaultOptions)
140+
return extenderOptionsDefaultOptions
141141
}
142142
} else if (optionsDOIsFn) {
143143
options.defaultOptions = function defaultOptions(opts, scope) {

src/providers/formlyConfig.test.js

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,68 @@ describe('formlyConfig', () => {
287287
})
288288

289289
})
290+
291+
describe(`abstractType function case`, () => {
292+
beforeEach(() => {
293+
setterFn([
294+
{
295+
name,
296+
template,
297+
defaultOptions: function(options) {
298+
return {
299+
templateOptions: {
300+
required: true,
301+
min: 3,
302+
},
303+
}
304+
},
305+
},
306+
{
307+
name: 'type2',
308+
extends: name,
309+
defaultOptions: function(options) {
310+
return {
311+
templateOptions: {
312+
required: false,
313+
max: 4,
314+
},
315+
}
316+
},
317+
},
318+
{
319+
name: 'type3',
320+
extends: name,
321+
defaultOptions: {
322+
templateOptions: {
323+
required: false,
324+
max: 4,
325+
},
326+
},
327+
},
328+
])
329+
})
330+
331+
it(`should merge options when extending defaultOptions is a function`, () => {
332+
expect(getterFn('type2').defaultOptions({})).to.eql({
333+
templateOptions: {
334+
required: false,
335+
min: 3,
336+
max: 4,
337+
},
338+
})
339+
})
340+
341+
it(`should merge options when extending defaultOptions is an object`, () => {
342+
expect(getterFn('type3').defaultOptions({})).to.eql({
343+
templateOptions: {
344+
required: false,
345+
min: 3,
346+
max: 4,
347+
},
348+
})
349+
})
350+
351+
})
290352

291353
describe(`template/templateUrl Cases`, () => {
292354
it('should use templateUrl if type defines it and its parent has template defined', function() {

0 commit comments

Comments
 (0)