Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 5f20bf1

Browse files
eugerossettoeugerossetto
authored
[file_selector] Use const instead of final for XTypeGroup. (#6542)
1 parent 54e748c commit 5f20bf1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+121
-328
lines changed

‎packages/file_selector/file_selector/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 0.9.2+1
22

3+
* Changes XTypeGroup initialization from final to const.
34
* Updates minimum Flutter version to 2.10.
45

56
## 0.9.2

‎packages/file_selector/file_selector/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Please also take a look at our [example][example] app.
3434
#### Open a single file
3535
<?code-excerpt "open_image_page.dart (SingleOpen)"?>
3636
``` dart
37-
final XTypeGroup typeGroup = XTypeGroup(
37+
const XTypeGroup typeGroup = XTypeGroup(
3838
label: 'images',
3939
extensions: <String>['jpg', 'png'],
4040
);
@@ -45,11 +45,11 @@ final XFile? file =
4545
#### Open multiple files at once
4646
<?code-excerpt "open_multiple_images_page.dart (MultiOpen)"?>
4747
``` dart
48-
final XTypeGroup jpgsTypeGroup = XTypeGroup(
48+
const XTypeGroup jpgsTypeGroup = XTypeGroup(
4949
label: 'JPEGs',
5050
extensions: <String>['jpg', 'jpeg'],
5151
);
52-
final XTypeGroup pngTypeGroup = XTypeGroup(
52+
const XTypeGroup pngTypeGroup = XTypeGroup(
5353
label: 'PNGs',
5454
extensions: <String>['png'],
5555
);

‎packages/file_selector/file_selector/example/lib/open_image_page.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
6-
// ignore_for_file: prefer_const_constructors, prefer_const_literals_to_create_immutables
7-
85
import 'dart:io';
96

107
import 'package:file_selector/file_selector.dart';
@@ -18,7 +15,7 @@ class OpenImagePage extends StatelessWidget {
1815

1916
Future<void> _openImageFile(BuildContext context) async {
2017
// #docregion SingleOpen
21-
final XTypeGroup typeGroup = XTypeGroup(
18+
const XTypeGroup typeGroup = XTypeGroup(
2219
label: 'images',
2320
extensions: <String>['jpg', 'png'],
2421
);

‎packages/file_selector/file_selector/example/lib/open_multiple_images_page.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
6-
// ignore_for_file: prefer_const_constructors, prefer_const_literals_to_create_immutables
7-
85
import 'dart:io';
96

107
import 'package:file_selector/file_selector.dart';
@@ -18,11 +15,11 @@ class OpenMultipleImagesPage extends StatelessWidget {
1815

1916
Future<void> _openImageFile(BuildContext context) async {
2017
// #docregion MultiOpen
21-
final XTypeGroup jpgsTypeGroup = XTypeGroup(
18+
const XTypeGroup jpgsTypeGroup = XTypeGroup(
2219
label: 'JPEGs',
2320
extensions: <String>['jpg', 'jpeg'],
2421
);
25-
final XTypeGroup pngTypeGroup = XTypeGroup(
22+
const XTypeGroup pngTypeGroup = XTypeGroup(
2623
label: 'PNGs',
2724
extensions: <String>['png'],
2825
);

‎packages/file_selector/file_selector/example/lib/open_text_page.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,8 @@ class OpenTextPage extends StatelessWidget {
1212
const OpenTextPage({Key? key}) : super(key: key);
1313

1414
Future<void> _openTextFile(BuildContext context) async {
15-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
16-
// ignore: prefer_const_constructors
17-
final XTypeGroup typeGroup = XTypeGroup(
15+
const XTypeGroup typeGroup = XTypeGroup(
1816
label: 'text',
19-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
20-
// ignore: prefer_const_literals_to_create_immutables
2117
extensions: <String>['txt', 'json'],
2218
);
2319
// This demonstrates using an initial directory for the prompt, which should

‎packages/file_selector/file_selector/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for opening and saving files, or selecting
33
directories, using native file selection UI.
44
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector
55
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
6-
version: 0.9.2
6+
version: 0.9.2+1
77

88
environment:
99
sdk: ">=2.12.0 <3.0.0"
@@ -27,7 +27,7 @@ dependencies:
2727
file_selector_ios: ^0.5.0
2828
file_selector_linux: ^0.9.0
2929
file_selector_macos: ^0.9.0
30-
file_selector_platform_interface: ^2.0.0
30+
file_selector_platform_interface: ^2.2.0
3131
file_selector_web: ^0.9.0
3232
file_selector_windows: ^0.9.0
3333
flutter:

‎packages/file_selector/file_selector/test/file_selector_test.dart

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
6-
// ignore_for_file: prefer_const_literals_to_create_immutables
7-
85
import 'package:file_selector/file_selector.dart';
96
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
107
import 'package:flutter_test/flutter_test.dart';
@@ -15,15 +12,11 @@ void main() {
1512
const String initialDirectory = '/home/flutteruser';
1613
const String confirmButtonText = 'Use this profile picture';
1714
const String suggestedName = 'suggested_name';
18-
final List<XTypeGroup> acceptedTypeGroups = <XTypeGroup>[
19-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
20-
// ignore: prefer_const_constructors
15+
const List<XTypeGroup> acceptedTypeGroups = <XTypeGroup>[
2116
XTypeGroup(label: 'documents', mimeTypes: <String>[
2217
'application/msword',
2318
'application/vnd.openxmlformats-officedocument.wordprocessing',
2419
]),
25-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
26-
// ignore: prefer_const_constructors
2720
XTypeGroup(label: 'images', extensions: <String>[
2821
'jpg',
2922
'png',

‎packages/file_selector/file_selector_ios/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 0.5.0+2
22

3+
* Changes XTypeGroup initialization from final to const.
34
* Updates minimum Flutter version to 2.10.
45

56
## 0.5.0+1

‎packages/file_selector/file_selector_ios/example/lib/open_image_page.dart

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,9 @@ class OpenImagePage extends StatelessWidget {
1515
const OpenImagePage({Key? key}) : super(key: key);
1616

1717
Future<void> _openImageFile(BuildContext context) async {
18-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
19-
// ignore: prefer_const_constructors
20-
final XTypeGroup typeGroup = XTypeGroup(
18+
const XTypeGroup typeGroup = XTypeGroup(
2119
label: 'images',
22-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
23-
// ignore: prefer_const_literals_to_create_immutables
2420
extensions: <String>['jpg', 'png'],
25-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
26-
// ignore: prefer_const_literals_to_create_immutables
2721
macUTIs: <String>['public.image'],
2822
);
2923
final XFile? file = await FileSelectorPlatform.instance

‎packages/file_selector/file_selector_ios/example/lib/open_multiple_images_page.dart

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
6-
// ignore_for_file: prefer_const_literals_to_create_immutables
7-
85
import 'dart:io';
96

107
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
@@ -18,16 +15,12 @@ class OpenMultipleImagesPage extends StatelessWidget {
1815
const OpenMultipleImagesPage({Key? key}) : super(key: key);
1916

2017
Future<void> _openImageFile(BuildContext context) async {
21-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
22-
// ignore: prefer_const_constructors
23-
final XTypeGroup jpgsTypeGroup = XTypeGroup(
18+
const XTypeGroup jpgsTypeGroup = XTypeGroup(
2419
label: 'JPEGs',
2520
extensions: <String>['jpg', 'jpeg'],
2621
macUTIs: <String>['public.jpeg'],
2722
);
28-
// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
29-
// ignore: prefer_const_constructors
30-
final XTypeGroup pngTypeGroup = XTypeGroup(
23+
const XTypeGroup pngTypeGroup = XTypeGroup(
3124
label: 'PNGs',
3225
extensions: <String>['png'],
3326
macUTIs: <String>['public.png'],

0 commit comments

Comments
 (0)