Skip to content

Commit 5e9e211

Browse files
authored
[local_auth_android] Fix Android lint warnings (#3764)
Removed lint-baseline.xml and fixed all warnings. The removal is mainly for unused resources that were identified by the `./gradlew lint` check. Part of flutter/flutter#88011
1 parent 9c592e0 commit 5e9e211

14 files changed

+30
-398
lines changed

packages/local_auth/local_auth_android/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.0.28
2+
3+
* Removes unused resources as indicated by Android lint warnings.
4+
15
## 1.0.27
26

37
* Fixes compatibility with AGP versions older than 4.2.

packages/local_auth/local_auth_android/android/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ android {
4242
checkAllWarnings true
4343
warningsAsErrors true
4444
disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
45-
baseline file("lint-baseline.xml")
4645
}
4746

4847

packages/local_auth/local_auth_android/android/lint-baseline.xml

Lines changed: 0 additions & 246 deletions
This file was deleted.

packages/local_auth/local_auth_android/android/src/main/res/drawable/fingerprint_initial_icon.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/local_auth/local_auth_android/android/src/main/res/drawable/fingerprint_success_icon.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/local_auth/local_auth_android/android/src/main/res/drawable/fingerprint_warning_icon.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/local_auth/local_auth_android/android/src/main/res/drawable/ic_done_white_24dp.xml

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/local_auth/local_auth_android/android/src/main/res/drawable/ic_fingerprint_white_24dp.xml

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/local_auth/local_auth_android/android/src/main/res/drawable/ic_priority_high_white_24dp.xml

Lines changed: 0 additions & 12 deletions
This file was deleted.
Lines changed: 25 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,30 @@
11
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
22
android:layout_width="match_parent"
33
android:layout_height="wrap_content"
4-
android:paddingLeft="24dp"
5-
android:paddingRight="24dp"
64
android:gravity="center_vertical"
7-
android:orientation="vertical">
8-
<TextView
9-
android:id="@+id/fingerprint_required"
10-
android:layout_width="wrap_content"
11-
android:layout_height="wrap_content"
12-
android:paddingTop="24dp"
13-
android:paddingBottom="20dp"
14-
android:gravity="center_vertical"
15-
android:textColor="@color/black_text"
16-
style="@android:style/TextAppearance.DeviceDefault.Medium"
17-
android:textSize="@dimen/huge_text_size"/>
18-
<TextView
19-
android:id="@+id/go_to_setting_description"
20-
android:layout_width="wrap_content"
21-
android:layout_height="wrap_content"
22-
android:paddingBottom="28dp"
23-
android:textColor="@color/grey_text"
24-
android:textStyle="normal"
25-
android:textSize="@dimen/medium_text_size"/>
5+
android:orientation="vertical"
6+
android:paddingLeft="24dp"
7+
android:paddingRight="24dp">
8+
9+
<TextView
10+
android:id="@+id/fingerprint_required"
11+
style="@android:style/TextAppearance.DeviceDefault.Medium"
12+
android:layout_width="wrap_content"
13+
android:layout_height="wrap_content"
14+
android:gravity="center_vertical"
15+
android:paddingTop="24dp"
16+
android:paddingBottom="20dp"
17+
android:textColor="@color/black_text"
18+
android:textIsSelectable="false"
19+
android:textSize="@dimen/huge_text_size" />
20+
21+
<TextView
22+
android:id="@+id/go_to_setting_description"
23+
android:layout_width="wrap_content"
24+
android:layout_height="wrap_content"
25+
android:paddingBottom="28dp"
26+
android:textColor="@color/grey_text"
27+
android:textIsSelectable="false"
28+
android:textSize="@dimen/medium_text_size"
29+
android:textStyle="normal" />
2630
</LinearLayout>

0 commit comments

Comments
 (0)