This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] remove SDF code paths. #41754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just delete it entirely? It'll be in the git history if we really need it. |
|
I was keeping it around for youuuu 😂. Deleting sgtm |
jonahwilliams
changed the title
dnfield
approved these changes
May 5, 2023
jonahwilliams
added
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 6, 2023
…126188) flutter/engine@b7c79b4...332f532 2023-05-06 [email protected] Roll Skia from bc0197405951 to 2e622658996c (1 revision) (flutter/engine#41789) 2023-05-05 [email protected] [Impeller] remove SDF code paths. (flutter/engine#41754) 2023-05-05 [email protected] Roll Fuchsia Linux SDK from jbpFz7qSikrKiRanC... to leCRDVJ8szOS2LsPV... (flutter/engine#41788) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from jbpFz7qSikrK to leCRDVJ8szOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
May 10, 2023
Creates a separate atlas context and cache for color and alpha bitmap glyphs. Removes SDF shader and uses separate shader for full color glyphs. Requires #41754 Fixes flutter/flutter#116818 Fixes flutter/flutter#126101 This also fixes #39383 but for light text on a dark background. This problem crops up when we switch to a full color atlas. In this context, the chosen glyph color is important. But with the alpha channel only atlas, its irrelevant. See diff:  Example app: ```dart // Copyright 2014 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. import 'package:flutter/material.dart'; import 'package:flutter/widgets.dart'; void main() => runApp( Container( alignment: Alignment.center, child: Text( ''' (Unicode Conference)Ø� اÙ�Ø°Ù� سÙ�عÙ�د Ù�Ù� 10-12 آذار 1997 بÙ�دÙ�Ù�Ø© Ù�Ù�اÙ�Ù�Ù�Ù�تÙ�سØ� Ø£Ù�Ù�اÙ�Ù�ا. Ù� سÙ�جÙ�ع اÙ�Ù�ؤتÙ�ر بÙ�Ù� خبراء Ù�Ù� Ù�اÙ�Ø© Ù�طاعات اÙ�صÙ�اعة عÙ�Ù� اÙ�شبÙ�Ø© اÙ�عاÙ�Ù�Ù�Ø© اÙ�ترÙ�Ù�ت Ù�Ù�Ù�Ù�Ù�Ù�Ù�دØ� ØÙ�Ø« ستتÙ�Ø� عÙ�Ù� اÙ�صعÙ�دÙ�Ù� اÙ�دÙ�Ù�Ù� Ù�اÙ�Ù�ØÙ�Ù� عÙ�Ù� Øد سÙ�اء Ù�Ù�اÙ�شة سبÙ� استخداÙ� Ù�Ù�Ù�Ù�Ù�د Ù�Ù� اÙ�Ù�ظÙ� اÙ�Ù�ائÙ�Ø© Ù�Ù�Ù�Ù�ا Ù�خص اÙ�تطبÙ�Ù�ات اÙ�ØاسÙ�بÙ�Ø©Ø� اÙ�خطÙ�Ø·Ø� تصÙ�Ù�Ù� اÙ�Ù�صÙ�ص Ù�اÙ�ØÙ�سبة Ù�تعددة اÙ�Ù�غات. Ù�Ù�Ù�Ù�Ù�Ù�Ù�Ù�Ù�Ù�Ù�Ù�ð��� ð��� ð��� ð��� ð���''', textDirection: TextDirection.rtl, style: TextStyle(fontSize: 24, color: Colors.white), ), ), ); ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my investigations, we're not likely to be able to use SDF in the near term. To make planned refactors of the text rendering easier to land, I've moved the primary piece of code for generating the SDFs into a new TU for testing.
The shader itself has been deleted so that we don't ship + register it.