From 8144eca3e576309d8defc7ef6a68745600ec1934 Mon Sep 17 00:00:00 2001 From: Jackson Gardner Date: Mon, 14 Nov 2022 14:54:41 -0800 Subject: [PATCH 1/2] Skip the skwasm unit test suite on Safari since it is flaky. --- lib/web_ui/dev/steps/run_tests_step.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/web_ui/dev/steps/run_tests_step.dart b/lib/web_ui/dev/steps/run_tests_step.dart index 72718608804ad..62578354d2c98 100644 --- a/lib/web_ui/dev/steps/run_tests_step.dart +++ b/lib/web_ui/dev/steps/run_tests_step.dart @@ -104,7 +104,9 @@ class RunTestsStep implements PipelineStep { testsPassed &= io.exitCode == 0; } - if (sortedTests.skwasmTests.isNotEmpty) { + // For some reason, Safari is flaky when running the Skwasm test suite + // See https://github.com/flutter/flutter/issues/115312 + if (browserName != kSafari && sortedTests.skwasmTests.isNotEmpty) { await _runTestBatch( testFiles: sortedTests.skwasmTests, renderer: Renderer.skwasm, From d352143e4d76be00ada4f077c8921d7ce63c8158 Mon Sep 17 00:00:00 2001 From: Jackson Gardner Date: Tue, 15 Nov 2022 08:11:47 -0800 Subject: [PATCH 2/2] Add TODO. --- lib/web_ui/dev/steps/run_tests_step.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/web_ui/dev/steps/run_tests_step.dart b/lib/web_ui/dev/steps/run_tests_step.dart index 62578354d2c98..b6d51154c7f27 100644 --- a/lib/web_ui/dev/steps/run_tests_step.dart +++ b/lib/web_ui/dev/steps/run_tests_step.dart @@ -104,9 +104,10 @@ class RunTestsStep implements PipelineStep { testsPassed &= io.exitCode == 0; } + // TODO(jacksongardner): enable this test suite on safari // For some reason, Safari is flaky when running the Skwasm test suite // See https://github.com/flutter/flutter/issues/115312 - if (browserName != kSafari && sortedTests.skwasmTests.isNotEmpty) { + if (browserName != kSafari && sortedTests.skwasmTests.isNotEmpty) { await _runTestBatch( testFiles: sortedTests.skwasmTests, renderer: Renderer.skwasm,