From 32b3ad9369e26061a42c815196d874762d00be19 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Wed, 9 Nov 2022 05:48:46 -0500 Subject: [PATCH] Use traingle strip for difference clip This was wrongly removed in https://github.com/flutter/engine/pull/37315/ where I assumed that this was overwritten by geometry_result a few lines below, but there is indeed a pipeline created earlier in line:100. Fixes: https://github.com/flutter/flutter/issues/114870 --- impeller/entity/contents/clip_contents.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/impeller/entity/contents/clip_contents.cc b/impeller/entity/contents/clip_contents.cc index a8b44c4a3d846..0e9aa6b623d97 100644 --- a/impeller/entity/contents/clip_contents.cc +++ b/impeller/entity/contents/clip_contents.cc @@ -96,6 +96,7 @@ bool ClipContents::Render(const ContentContext& renderer, info.mvp = Matrix::MakeOrthographic(pass.GetRenderTargetSize()); VS::BindVertInfo(cmd, pass.GetTransientsBuffer().EmplaceUniform(info)); + options.primitive_type = PrimitiveType::kTriangleStrip; cmd.pipeline = renderer.GetClipPipeline(options); pass.AddCommand(cmd); }