Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e6fc470

Browse files
committed
[Impeller] turned on new blur
1 parent a565cea commit e6fc470

File tree

2 files changed

+7
-32
lines changed

2 files changed

+7
-32
lines changed

impeller/entity/contents/filters/directional_gaussian_blur_filter_contents.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ namespace impeller {
4343
/// - `FilterContents::MakeGaussianBlur`
4444
/// - //flutter/impeller/entity/shaders/gaussian_blur/gaussian_blur.glsl
4545
///
46+
///\deprecated Previously 2 of these were chained to do 2D blurs, use
47+
/// \ref GaussianBlurFilterContents instead since it has better
48+
/// performance.
4649
class DirectionalGaussianBlurFilterContents final : public FilterContents {
4750
public:
4851
DirectionalGaussianBlurFilterContents();

impeller/entity/contents/filters/filter_contents.cc

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -56,38 +56,10 @@ std::shared_ptr<FilterContents> FilterContents::MakeGaussianBlur(
5656
Sigma sigma_y,
5757
BlurStyle blur_style,
5858
Entity::TileMode tile_mode) {
59-
constexpr bool use_new_filter =
60-
#ifdef IMPELLER_ENABLE_NEW_GAUSSIAN_FILTER
61-
true;
62-
#else
63-
false;
64-
#endif
65-
66-
// TODO(https://github.com/flutter/flutter/issues/131580): Remove once the new
67-
// blur handles all cases.
68-
if (use_new_filter) {
69-
auto blur = std::make_shared<GaussianBlurFilterContents>(
70-
sigma_x.sigma, sigma_y.sigma, tile_mode);
71-
blur->SetInputs({input});
72-
return blur;
73-
}
74-
std::shared_ptr<FilterContents> x_blur = MakeDirectionalGaussianBlur(
75-
/*input=*/input,
76-
/*sigma=*/sigma_x,
77-
/*direction=*/Point(1, 0),
78-
/*blur_style=*/BlurStyle::kNormal,
79-
/*tile_mode=*/tile_mode,
80-
/*is_second_pass=*/false,
81-
/*secondary_sigma=*/{});
82-
std::shared_ptr<FilterContents> y_blur = MakeDirectionalGaussianBlur(
83-
/*input=*/FilterInput::Make(x_blur),
84-
/*sigma=*/sigma_y,
85-
/*direction=*/Point(0, 1),
86-
/*blur_style=*/blur_style,
87-
/*tile_mode=*/tile_mode,
88-
/*is_second_pass=*/true,
89-
/*secondary_sigma=*/sigma_x);
90-
return y_blur;
59+
auto blur = std::make_shared<GaussianBlurFilterContents>(
60+
sigma_x.sigma, sigma_y.sigma, tile_mode);
61+
blur->SetInputs({input});
62+
return blur;
9163
}
9264

9365
std::shared_ptr<FilterContents> FilterContents::MakeBorderMaskBlur(

0 commit comments

Comments
 (0)