Make impeller/aiks/... compatible with .clang-tidy.

Author: matanlurey

impeller/aiks/canvas_recorder.h

@@ -16,6 +16,7 @@ namespace impeller {
 /// golden tests can be written at a higher level, migrate these to
 /// flutter::DisplayListOpType.
 enum CanvasRecorderOp : uint16_t {
+  // NOLINTBEGIN(readability-identifier-naming)
   New,
   Save,
   SaveLayer,
@@ -45,6 +46,7 @@ enum CanvasRecorderOp : uint16_t {
   DrawTextFrame,
   DrawVertices,
   DrawAtlas,
+  // NOLINTEND(readability-identifier-naming)
 };
 
 // Canvas recorder should only be used when IMPELLER_TRACE_CANVAS is defined

impeller/aiks/image.h

@@ -13,7 +13,7 @@ namespace impeller {
 
 class Image {
  public:
-  Image(std::shared_ptr<Texture> texture);
+  explicit Image(std::shared_ptr<Texture> texture);
 
   ~Image();
 

impeller/aiks/testing/context_mock.h

@@ -5,6 +5,7 @@
 #pragma once
 
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "gmock/gmock-function-mocker.h"
@@ -18,8 +19,8 @@ namespace testing {
 
 class CommandBufferMock : public CommandBuffer {
  public:
-  CommandBufferMock(std::weak_ptr<const Context> context)
-      : CommandBuffer(context) {}
+  explicit CommandBufferMock(std::weak_ptr<const Context> context)
+      : CommandBuffer(std::move(context)) {}
 
   MOCK_METHOD(bool, IsValid, (), (const, override));
 
@@ -32,7 +33,7 @@ class CommandBufferMock : public CommandBuffer {
 
   static std::shared_ptr<RenderPass> ForwardOnCreateRenderPass(
       CommandBuffer* command_buffer,
-      RenderTarget render_target) {
+      const RenderTarget& render_target) {
     return command_buffer->OnCreateRenderPass(render_target);
   }
 
@@ -48,7 +49,7 @@ class CommandBufferMock : public CommandBuffer {
               (override));
   static bool ForwardOnSubmitCommands(CommandBuffer* command_buffer,
                                       CompletionCallback callback) {
-    return command_buffer->OnSubmitCommands(callback);
+    return command_buffer->OnSubmitCommands(std::move(callback));
   }
 
   MOCK_METHOD(void, OnWaitUntilScheduled, (), (override));