Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit cf074be

Browse files
committed
Merge pull request #2 from abarth/creating_pull_requests
Add instructions for creating pull requests
2 parents 51b9fa4 + 05ed2cb commit cf074be

File tree

1 file changed

+20
-12
lines changed

1 file changed

+20
-12
lines changed

CONTRIBUTING.md

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ Getting the code
66

77
To get the code:
88

9-
1. Fork https://github.com/domokit/sky_engine into your own GitHub account.
10-
2. [Download depot_tools](http://www.chromium.org/developers/how-tos/install-depot-tools)
11-
and make sure it is in your path.
12-
3. Create a `.gclient` file in an empty directory with the following contents:
9+
* Fork https://github.com/domokit/sky_engine into your own GitHub account.
10+
* [Download depot_tools](http://www.chromium.org/developers/how-tos/install-depot-tools)
11+
and make sure it is in your path.
12+
* Create a `.gclient` file in an empty directory with the following contents:
1313

1414
```
1515
solutions = [
@@ -25,19 +25,27 @@ solutions = [
2525
target_os = ["android"]
2626
```
2727

28-
4. `svn ls https://dart.googlecode.com/` and accept the certificate permanently.
29-
5. `gclient sync`
30-
6. `cd src`
31-
7. `git remote add upstream [email protected]:domokit/sky_engine.git`
32-
8. `./build/install-build-deps.sh`
28+
* `svn ls https://dart.googlecode.com/` and accept the certificate permanently.
29+
* `gclient sync`
30+
* `cd src`
31+
* `git remote add upstream [email protected]:domokit/sky_engine.git`
32+
* `./build/install-build-deps.sh`
3333

3434
Building the code
3535
-----------------
3636

37-
1. `./mojo/tools/mojob gn`
38-
2. `ninja -C out/Debug`
37+
* `./mojo/tools/mojob gn`
38+
* `ninja -C out/Debug`
3939

4040
Contributing code
4141
-----------------
4242

43-
The Sky engine repository gladly accepts contributions via GitHub pull requests.
43+
The Sky engine repository gladly accepts contributions via GitHub pull requests:
44+
45+
* `git fetch upstream`
46+
* `git checkout upstream/master -b name_of_your_branch`
47+
* Hack away
48+
* `git commit -a`
49+
* `git push origin name_of_your_branch`
50+
* Go to `https://github.com/<your_name_here>/sky_engine` and click the
51+
"Compare & pull request" button

0 commit comments

Comments
 (0)