Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c0ca187

Browse files
mkustermanncommit-bot@chromium.org
authored andcommitted
Revert "Create the frontend_server snapshot as a part of the sdk"
This reverts commit 24a0601. Reason for revert: This breaks the flutter build because flutter has a build target producing the same "gen/frontend_server.dart.snapshot" file and is therefore conflicting. See e.g. head-head-head bot failure: https://ci.chromium.org/p/dart/builders/ci.sandbox/flutter-engine-linux/9747 Original change's description: > Create the frontend_server snapshot as a part of the sdk > > This will allow us to use it from webdev, as it now supports DDC output. > > Change-Id: I4b82d1c45d2c058abb062dddd2a2c41cc6318c45 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130134 > Reviewed-by: Keerti Parthasarathy <[email protected]> > Reviewed-by: Jonah Williams <[email protected]> > Reviewed-by: Vijay Menon <[email protected]> > Commit-Queue: Jake Macdonald <[email protected]> [email protected],[email protected],[email protected],[email protected] Change-Id: Ib2d782560cc005416ece429f9506dca055bffd9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130377 Reviewed-by: Martin Kustermann <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent c218b43 commit c0ca187

File tree

3 files changed

+1
-21
lines changed

3 files changed

+1
-21
lines changed

sdk/BUILD.gn

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,6 @@ _full_sdk_snapshots = [
182182
"pub",
183183
"../utils/pub",
184184
],
185-
[
186-
"frontend_server",
187-
"../utils/kernel-service:frontend_server",
188-
],
189185
]
190186
if (include_dart2native && dart_target_arch != "ia32") {
191187
_full_sdk_snapshots += [ [

sdk_nnbd/BUILD.gn

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,6 @@ _full_sdk_snapshots = [
182182
"pub",
183183
"../utils/pub",
184184
],
185-
[
186-
"frontend_server",
187-
"../utils/kernel-service:frontend_server",
188-
],
189185
]
190186
if (include_dart2native && dart_target_arch != "ia32") {
191187
_full_sdk_snapshots += [ [

utils/kernel-service/BUILD.gn

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,7 @@ application_snapshot("frontend_server") {
5959
"--platform=$sdk_root/vm_platform_strong.dill",
6060
rebase_path(main_dart),
6161
]
62-
output = "$root_gen_dir/frontend_server.dart.snapshot"
63-
}
64-
65-
copy("copy_frontend_server") {
66-
deps = [
67-
":frontend_server",
68-
]
69-
sources = [
70-
"$root_gen_dir/frontend_server.dart.snapshot",
71-
]
72-
outputs = [
73-
"$root_out_dir/frontend_server.dart.snapshot",
74-
]
62+
output = "$root_out_dir/frontend_server.dart.snapshot"
7563
}
7664

7765
template("kernel_service_dill") {

0 commit comments

Comments
 (0)