Version 2.11.0-182.0.dev

Merge commit '68fd2a9d52802bdcc2db31d9b31a2e128b392f30' into 'dev'

Author: Dart CI

CHANGELOG.md

@@ -2,11 +2,16 @@
 
 ### Core libraries
 
+#### `dart:io`
+
+*   `HttpRequest` will now correctly follow HTTP 308 redirects
+    (`HttpStatus.permanentRedirect`).
+
 ### Dart VM
 
 ### Dart2JS
 
-* Removed `--no-defer-class-types` and `--no-new-deferred-split'.
+* Removed `--no-defer-class-types` and `--no-new-deferred-split`.
 
 ### Tools
 
@@ -18,8 +23,13 @@
 
 #### Linter
 
-Updated the Linter to `0.1.119`, which includes:
+Updated the Linter to `0.1.120`, which includes:
 
+* New lint: `cast_nullable_to_non_nullable`.
+* New lint: `null_check_on_nullable_type_parameter`.
+* New lint: `tighten_type_of_initializing_formals`.
+* Updates to `public_member_apis` to check generic type aliases.
+* (Internal): updates to adopt new analyzer APIs.
 * Fixed `close_sinks` to handle `this`-prefixed property accesses.
 * New lint: `unnecessary_null_checks`.
 * Fixed `unawaited_futures` to handle `Future` subtypes.
@@ -157,9 +167,14 @@ applications (issue [flutter/flutter#63038][]).
 *   [Abstract Unix Domain Socket][] is supported on Linux/Android now. Using an
     `InternetAddress` with `address` starting with '@' and type being
     `InternetAddressType.Unix` will create an abstract Unix Domain Socket.
+*   On Windows, file APIs can now handle files and directories identified by
+    long paths (greater than 260 characters). It complies with all restrictions
+    from [Long Path on Windows][]. Note that `Directory.current` does not work
+    with long path.
 
 [#42006]: https://github.com/dart-lang/sdk/issues/42006
 [Abstract Unix Domain Socket]: http://man7.org/linux/man-pages/man7/unix.7.html
+[Long Path on Windows]: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#maximum-path-length-limitation
 
 #### `dart:html`
 

DEPS

@@ -113,7 +113,7 @@ vars = {
   "intl_tag": "0.16.1",
   "jinja2_rev": "2222b31554f03e62600cd7e383376a7c187967a1",
   "json_rpc_2_rev": "8f189db8f0c299187a0e8fa959dba7e9b0254be5",
-  "linter_tag": "0.1.119",
+  "linter_tag": "0.1.120",
   "logging_rev": "1590ba0b648a51e7eb3895c612e4b72f72623b6f",
   "markupsafe_rev": "8f45f5cfa0009d2a70589bcda0349b8cb2b72783",
   "markdown_rev": "dbeafd47759e7dd0a167602153bb9c49fb5e5fe7",

pkg/_fe_analyzer_shared/lib/src/flow_analysis/flow_analysis.dart

@@ -1050,7 +1050,8 @@ class FlowAnalysisDebug<Node, Statement extends Node, Expression, Variable,
 
   @override
   bool isUnassigned(Variable variable) {
-    return _wrap('isUnassigned($variable)', () => _wrapped.isAssigned(variable),
+    return _wrap(
+        'isUnassigned($variable)', () => _wrapped.isUnassigned(variable),
         isQuery: true);
   }
 

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -1111,17 +1111,17 @@ const Code<Null> codeConstConstructorLateFinalFieldCause =
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const MessageCode messageConstConstructorLateFinalFieldCause =
     const MessageCode("ConstConstructorLateFinalFieldCause",
-        severity: Severity.context,
-        message: r"""Field is late, but constructor is 'const'.""");
+        severity: Severity.context, message: r"""This constructor is const.""");
 
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeConstConstructorLateFinalFieldError =
     messageConstConstructorLateFinalFieldError;
 
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageConstConstructorLateFinalFieldError =
-    const MessageCode("ConstConstructorLateFinalFieldError",
-        message: r"""Constructor is marked 'const' so fields can't be late.""");
+const MessageCode messageConstConstructorLateFinalFieldError = const MessageCode(
+    "ConstConstructorLateFinalFieldError",
+    message:
+        r"""Can't have a late final field in a class with a const constructor.""");
 
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeConstConstructorNonFinalField =

pkg/_fe_analyzer_shared/test/flow_analysis/definite_unassignment/data/late_initializer.dart

@@ -6,6 +6,8 @@
 // doesn't execute immediately, so it may refer to other late variables that
 // aren't assigned yet.
 
+void use(Object? x) {}
+
 eagerInitializerRefersToLateVar() {
   late int x;
   int y = /*unassigned*/ x;
@@ -17,3 +19,9 @@ lateInitializerRefersToLateVar() {
   late int y = x;
   x = 0;
 }
+
+lateInitializerIsAssignment() {
+  late int y;
+  late int z1 = y = 3;
+  use(y);
+}

pkg/_fe_analyzer_shared/test/flow_analysis/type_promotion/data/initialization.dart

@@ -55,18 +55,6 @@ localVariable_ifElse_sameTypes(bool a) {
   x;
 }
 
-localVariable_initialized_nonNull() {
-  num? x = 0;
-  /*num*/ x;
-  x = null;
-  x;
-}
-
-localVariable_initialized_nonNull_final() {
-  final num? x = 0;
-  x;
-}
-
 localVariable_initialized_promoted_type_var<T>(T t) {
   if (t is num) {
     var x = /*T & num*/ t;
@@ -106,13 +94,13 @@ localVariable_initialized_unpromoted_type_var_with_bound<T extends num?>(T t) {
 
 localVariable_initialized_promoted_type_var_typed<T>(T t) {
   if (t is num) {
-    // This should promote to `T & Object`, because that's the non-nullable
-    // version of T, but it shouldn't promote to `T & num`.
+    // TODO(paulberry): This should promote to `T & Object`, because that's the
+    // non-nullable version of T, but it shouldn't promote to `T & num`.
     T x = /*T & num*/ t;
-    /*T & Object*/ x;
+    x;
     // Check that `T & Object` is a type of interest by promoting and then
     // writing to it
-    if (/*T & Object*/ x is int) {
+    if (x is int) {
       /*T & int*/ x;
       x = /*T & num*/ t;
       /*T & Object*/ x;

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -70,12 +70,13 @@ import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dar
 /// A fix producer that produces changes to fix multiple diagnostics.
 class BulkFixProcessor {
   /// A map from the name of a lint rule to a list of generators used to create
-  /// the correction producer used to build a fix for that diagnostic. Most
-  /// entries will have only one generator.  In cases where there is more than
-  /// one, they will be applied in series and the expectation is that only one
-  /// will produce a change for a given fix. If more than one change is produced
-  /// the result will almost certainly be invalid code. The generators used for
-  /// non-lint diagnostics are in the [nonLintProducerMap].
+  /// the correction producer used to build a fix for that diagnostic. The
+  /// generators used for non-lint diagnostics are in the [nonLintProducerMap].
+  ///
+  /// Most entries will have only one generator. In cases where there is more
+  /// than one, they will be applied in series and the expectation is that only
+  /// one will produce a change for a given fix. If more than one change is
+  /// produced the result will almost certainly be invalid code.
   static const Map<String, List<ProducerGenerator>> lintProducerMap = {
     LintNames.annotate_overrides: [
       AddOverride.newInstance,
@@ -241,9 +242,13 @@ class BulkFixProcessor {
     ],
   };
 
-  /// A map from error codes to a list of generators used to create multiple
+  /// A map from an error code to a list of generators used to create multiple
   /// correction producers used to build fixes for those diagnostics. The
   /// generators used for lint rules are in the [lintMultiProducerMap].
+  ///
+  /// The expectation is that only one of the correction producers will produce
+  /// a change for a given fix. If more than one change is produced the result
+  /// will almost certainly be invalid code.
   static const Map<ErrorCode, List<MultiProducerGenerator>>
       nonLintMultiProducerMap = {
     CompileTimeErrorCode.EXTENDS_NON_CLASS: [
@@ -304,14 +309,12 @@ class BulkFixProcessor {
     CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_METHOD: [
       DataDriven.newInstance,
     ],
-    // TODO(brianwilkerson) Uncomment the entries below as we add tests for
-    //  them.
-    // HintCode.DEPRECATED_MEMBER_USE: [
-    //   DataDriven.newInstance,
-    // ],
-    // HintCode.DEPRECATED_MEMBER_USE_WITH_MESSAGE: [
-    //   DataDriven.newInstance,
-    // ],
+    HintCode.DEPRECATED_MEMBER_USE: [
+      DataDriven.newInstance,
+    ],
+    HintCode.DEPRECATED_MEMBER_USE_WITH_MESSAGE: [
+      DataDriven.newInstance,
+    ],
     HintCode.OVERRIDE_ON_NON_OVERRIDING_METHOD: [
       DataDriven.newInstance,
     ],
@@ -322,16 +325,22 @@ class BulkFixProcessor {
   /// lint rules are in the [lintProducerMap].
   static const Map<ErrorCode, ProducerGenerator> nonLintProducerMap = {};
 
+  /// Information about the workspace containing the libraries in which changes
+  /// will be produced.
   final DartChangeWorkspace workspace;
 
   /// The change builder used to build the changes required to fix the
   /// diagnostics.
   ChangeBuilder builder;
 
+  /// Initialize a newly created processor to create fixes for diagnostics in
+  /// libraries in the [workspace].
   BulkFixProcessor(this.workspace) {
     builder = ChangeBuilder(workspace: workspace);
   }
 
+  /// Return a change builder that has been used to create fixes for the
+  /// diagnostics in the libraries at the given [libraryPaths].
   Future<ChangeBuilder> fixErrorsInLibraries(List<String> libraryPaths) async {
     for (var path in libraryPaths) {
       var session = workspace.getSession(path);
@@ -344,8 +353,10 @@ class BulkFixProcessor {
     return builder;
   }
 
-  Future<void> _fixErrorsInLibrary(ResolvedLibraryResult libraryResult) async {
-    for (var unitResult in libraryResult.units) {
+  /// Use the change [builder] to create fixes for the diagnostics in the
+  /// library associated with the analysis [result].
+  Future<void> _fixErrorsInLibrary(ResolvedLibraryResult result) async {
+    for (var unitResult in result.units) {
       final fixContext = DartFixContextImpl(
         workspace,
         unitResult,
@@ -358,14 +369,17 @@ class BulkFixProcessor {
     }
   }
 
+  /// Use the change [builder] and the [fixContext] to create a fix for the
+  /// given [diagnostic] in the compilation unit associated with the analysis
+  /// [result].
   Future<void> _fixSingleError(DartFixContext fixContext,
-      ResolvedUnitResult unitResult, AnalysisError error) async {
+      ResolvedUnitResult result, AnalysisError diagnostic) async {
     var context = CorrectionProducerContext(
       dartFixContext: fixContext,
-      diagnostic: error,
-      resolvedResult: unitResult,
-      selectionOffset: error.offset,
-      selectionLength: error.length,
+      diagnostic: diagnostic,
+      resolvedResult: result,
+      selectionOffset: diagnostic.offset,
+      selectionLength: diagnostic.length,
       workspace: workspace,
     );
 
@@ -379,7 +393,7 @@ class BulkFixProcessor {
       await producer.compute(builder);
     }
 
-    var errorCode = error.errorCode;
+    var errorCode = diagnostic.errorCode;
     if (errorCode is LintCode) {
       var generators = lintProducerMap[errorCode.name];
       if (generators != null) {

pkg/analysis_server/lib/src/services/correction/dart/remove_comparison.dart

@@ -0,0 +1,103 @@
+// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analysis_server/src/services/correction/dart/abstract_producer.dart';
+import 'package:analysis_server/src/services/correction/fix.dart';
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/ast/token.dart';
+import 'package:analyzer/error/error.dart';
+import 'package:analyzer/source/source_range.dart';
+import 'package:analyzer/src/dart/error/hint_codes.dart';
+import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
+import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
+import 'package:analyzer_plugin/utilities/range_factory.dart';
+
+class RemoveComparison extends CorrectionProducer {
+  @override
+  FixKind get fixKind => DartFixKind.REMOVE_COMPARISON;
+
+  /// Return `true` if the null comparison will always return `false`.
+  bool get _conditionIsFalse =>
+      (diagnostic as AnalysisError).errorCode ==
+      HintCode.UNNECESSARY_NULL_COMPARISON_FALSE;
+
+  /// Return `true` if the null comparison will always return `true`.
+  bool get _conditionIsTrue =>
+      (diagnostic as AnalysisError).errorCode ==
+      HintCode.UNNECESSARY_NULL_COMPARISON_TRUE;
+
+  @override
+  Future<void> compute(ChangeBuilder builder) async {
+    if (node is! BinaryExpression) {
+      return;
+    }
+    var binaryExpression = node as BinaryExpression;
+    var parent = binaryExpression.parent;
+    if (parent is AssertInitializer && _conditionIsTrue) {
+      var constructor = parent.parent as ConstructorDeclaration;
+      var list = constructor.initializers;
+      if (list.length == 1) {
+        await builder.addDartFileEdit(file, (builder) {
+          builder.addDeletion(range.endEnd(constructor.parameters, parent));
+        });
+      } else {
+        await builder.addDartFileEdit(file, (builder) {
+          builder.addDeletion(range.nodeInList(list, parent));
+        });
+      }
+    } else if (parent is AssertStatement && _conditionIsTrue) {
+      await builder.addDartFileEdit(file, (builder) {
+        builder.addDeletion(utils.getLinesRange(range.node(parent)));
+      });
+    } else if (parent is BinaryExpression) {
+      if (parent.operator.type == TokenType.AMPERSAND_AMPERSAND &&
+          _conditionIsTrue) {
+        await _removeOperatorAndOperand(builder, parent, node);
+      } else if (parent.operator.type == TokenType.BAR_BAR &&
+          _conditionIsFalse) {
+        await _removeOperatorAndOperand(builder, parent, node);
+      }
+    } else if (parent is IfStatement) {
+      if (parent.elseStatement == null && _conditionIsTrue) {
+        var body = _extractBody(parent);
+        body = utils.indentSourceLeftRight(body);
+        await builder.addDartFileEdit(file, (builder) {
+          builder.addSimpleReplacement(
+              range.startOffsetEndOffset(
+                  parent.offset, utils.getLineContentEnd(parent.end)),
+              body);
+        });
+      }
+    }
+  }
+
+  String _extractBody(IfStatement statement) {
+    var body = statement.thenStatement;
+    if (body is Block) {
+      var statements = body.statements;
+      return utils.getRangeText(range.startOffsetEndOffset(
+          statements.first.offset,
+          utils.getLineContentEnd(statements.last.end)));
+    }
+    return utils.getNodeText(body);
+  }
+
+  /// Use the [builder] to add an edit to delete the operator and given
+  /// [operand] from the [binary] expression.
+  Future<void> _removeOperatorAndOperand(ChangeBuilder builder,
+      BinaryExpression binary, Expression operand) async {
+    SourceRange operatorAndOperand;
+    if (binary.leftOperand == node) {
+      operatorAndOperand = range.startStart(node, binary.rightOperand);
+    } else {
+      operatorAndOperand = range.endEnd(binary.leftOperand, node);
+    }
+    await builder.addDartFileEdit(file, (builder) {
+      builder.addDeletion(operatorAndOperand);
+    });
+  }
+
+  /// Return an instance of this class. Used as a tear-off in `FixProcessor`.
+  static RemoveComparison newInstance() => RemoveComparison();
+}

pkg/analysis_server/lib/src/services/correction/fix.dart

@@ -335,6 +335,8 @@ class DartFixKind {
       FixKind('dart.fix.remove.argument', 50, 'Remove argument');
   static const REMOVE_AWAIT =
       FixKind('dart.fix.remove.await', 50, 'Remove await');
+  static const REMOVE_COMPARISON =
+      FixKind('dart.fix.remove.comparison', 50, 'Remove comparison');
   static const REMOVE_CONST =
       FixKind('dart.fix.remove.const', 50, 'Remove const');
   static const REMOVE_DEAD_CODE =