[use dyanmic offscreen position based on UIScreen

Author: hellohuanlin

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -34,13 +34,6 @@
 // returns kInvalidFirstRect, iOS will not show the IME candidates view.
 const CGRect kInvalidFirstRect = {{-1, -1}, {9999, 9999}};
 
-// Position FlutterTextInputView outside of the screen (if scribble is disabled).
-// This is to fix a bug where native auto-correction highlight is displayed on
-// top left corner of the screen (See: https://github.com/flutter/flutter/issues/131695)
-// and a bug where the native auto-correction suggestion menu displayed (See:
-// https://github.com/flutter/flutter/issues/130818).
-const CGRect kNonScribbleInputHiderOffScreenRect = {{0, -2000}, {0, 0}};
-
 #pragma mark - TextInput channel method names.
 // See https://api.flutter.dev/flutter/services/SystemChannels/textInput-constant.html
 static NSString* const kShowMethod = @"TextInput.show";
@@ -2259,7 +2252,6 @@ - (instancetype)initWithDelegate:(id<FlutterTextInputDelegate>)textInputDelegate
     _textInputDelegate = textInputDelegate;
     _autofillContext = [[NSMutableDictionary alloc] init];
     _inputHider = [[FlutterTextInputViewAccessibilityHider alloc] init];
-    _inputHider.frame = kNonScribbleInputHiderOffScreenRect;
     _scribbleElements = [[NSMutableDictionary alloc] init];
     _keyboardViewContainer = [[UIView alloc] init];
 
@@ -2470,7 +2462,15 @@ - (void)setEditableSizeAndTransform:(NSDictionary*)dictionary {
         CGRectMake(0, 0, [dictionary[@"width"] intValue], [dictionary[@"height"] intValue]);
     _activeView.tintColor = [UIColor clearColor];
   } else {
-    _inputHider.frame = kNonScribbleInputHiderOffScreenRect;
+    // Screen must be loaded at this point.
+    UIScreen* screen = _viewController.flutterScreenIfViewLoaded;
+
+    // Position FlutterTextInputView outside of the screen (if scribble is disabled).
+    // This is to fix a bug where native auto-correction highlight is displayed on
+    // top left corner of the screen (See: https://github.com/flutter/flutter/issues/131695)
+    // and a bug where the native auto-correction suggestion menu displayed (See:
+    // https://github.com/flutter/flutter/issues/130818).
+    _inputHider.frame = CGRectMake(0, -screen.bounds.size.height, 0, 0);
   }
 }
 

shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm

@@ -2305,26 +2305,22 @@ - (void)testInitialActiveViewCantAccessTextInputDelegate {
   XCTAssertNil(textInputPlugin.activeView.textInputDelegate);
 }
 
-- (void)testInputHiderIsInitiallyOffScreen {
-  FlutterTextInputPlugin* myInputPlugin =
-      [[FlutterTextInputPlugin alloc] initWithDelegate:OCMClassMock([FlutterEngine class])];
-
-  FlutterMethodCall* setClientCall =
-      [FlutterMethodCall methodCallWithMethodName:@"TextInput.setClient"
-                                        arguments:@[ @(123), self.mutableTemplateCopy ]];
-  [myInputPlugin handleMethodCall:setClientCall
-                           result:^(id _Nullable result){
-                           }];
-
-  CGRect offScreenRect = {{0, -2000}, {0, 0}};
-
-  XCTAssert(CGRectEqualToRect(myInputPlugin.inputHider.frame, offScreenRect),
-            @"The initial input hider should be offScreen.");
-}
-
 - (void)testInputHiderIsOffScreenWhenScribbleIsDisabled {
   FlutterTextInputPlugin* myInputPlugin =
       [[FlutterTextInputPlugin alloc] initWithDelegate:OCMClassMock([FlutterEngine class])];
+  myInputPlugin.viewController = viewController;
+
+  NSSet<UIScene*>* scenes = UIApplication.sharedApplication.connectedScenes;
+  XCTAssertEqual(scenes.count, 1UL, @"There must only be 1 scene for test");
+  UIScene* scene = scenes.anyObject;
+  XCTAssert([scene isKindOfClass:[UIWindowScene class]], @"Must be a window scene for test");
+  UIWindowScene* windowScene = (UIWindowScene*)scene;
+  XCTAssert(windowScene.windows.count > 0, @"There must be at least 1 window for test");
+  UIWindow* window = windowScene.windows[0];
+  [window addSubview:viewController.view];
+  [viewController loadView];
+  UIScreen* screen = viewController.flutterScreenIfViewLoaded;
+  XCTAssertNotNil(screen, @"Screen must be present at this point");
 
   FlutterMethodCall* setClientCall =
       [FlutterMethodCall methodCallWithMethodName:@"TextInput.setClient"
@@ -2333,8 +2329,6 @@ - (void)testInputHiderIsOffScreenWhenScribbleIsDisabled {
                            result:^(id _Nullable result){
                            }];
 
-  CGRect offScreenRect = {{0, -2000}, {0, 0}};
-
   FlutterTextInputView* mockInputView = OCMPartialMock(myInputPlugin.activeView);
   OCMStub([mockInputView isScribbleAvailable]).andReturn(NO);
 
@@ -2348,6 +2342,7 @@ - (void)testInputHiderIsOffScreenWhenScribbleIsDisabled {
                            result:^(id _Nullable result){
                            }];
 
+  CGRect offScreenRect = CGRectMake(0, -screen.bounds.size.height, 0, 0);
   XCTAssert(CGRectEqualToRect(myInputPlugin.inputHider.frame, offScreenRect),
             @"The input hider should stay offScreen if scribble is disabled.");
 }