Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 70bd05e

Browse files
munificentcommit-bot@chromium.org
authored andcommitted
Stop ignoring runtime cast failures on function types.
Change-Id: Id3485e04aafea988604663e893818672d98dc8b0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103662 Reviewed-by: Vijay Menon <[email protected]> Commit-Queue: Bob Nystrom <[email protected]>
1 parent eff6e95 commit 70bd05e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,9 +434,8 @@ bool _ignoreTypeFailure(Object t1, Object t2) {
434434
result =
435435
_ignoreTypeFailure(t1, typeFuture) || _ignoreTypeFailure(t1, typeArg);
436436
} else {
437-
result = t1 is FunctionType && t2 is FunctionType ||
438-
isSubtypeOf(t2, unwrapType(Iterable)) &&
439-
isSubtypeOf(t1, unwrapType(Iterable));
437+
result = isSubtypeOf(t2, unwrapType(Iterable)) &&
438+
isSubtypeOf(t1, unwrapType(Iterable));
440439
if (result) {
441440
_warn('Ignoring cast fail from ${typeName(t1)} to ${typeName(t2)}');
442441
}

0 commit comments

Comments
 (0)