Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5de9e67

Browse files
committed
Clean up logging and comments
1 parent 145fa27 commit 5de9e67

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,6 @@ private void updateEditingState() {
154154
currentValue.composingStart,
155155
currentValue.composingEnd);
156156

157-
// TODO(justinmc): This must be where the engine sends a value to the frmwk.
158-
Log.e("justin", "Android engine sending to framework " + currentValue.text);
159157
textInputChannel.updateEditingState(
160158
mClient,
161159
currentValue.text,
@@ -190,9 +188,6 @@ public boolean beginBatchEdit() {
190188

191189
@Override
192190
public boolean endBatchEdit() {
193-
// TODO(justinmc): This is how Android is able to batch requests.
194-
// Should iOS do the same? Or is there another way to work around this?
195-
Log.e("justin", "endBatchEdit");
196191
boolean result = super.endBatchEdit();
197192
mBatchCount--;
198193
updateEditingState();

shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import androidx.annotation.NonNull;
2727
import androidx.annotation.Nullable;
2828
import androidx.annotation.VisibleForTesting;
29-
import io.flutter.Log;
3029
import io.flutter.embedding.engine.systemchannels.TextInputChannel;
3130
import io.flutter.plugin.platform.PlatformViewsController;
3231
import java.util.HashMap;
@@ -96,11 +95,6 @@ public void setPlatformViewClient(int platformViewId) {
9695

9796
@Override
9897
public void setEditingState(TextInputChannel.TextEditState editingState) {
99-
// TODO(justinmc): I believe this is where the framework sends a
100-
// value to the engine.
101-
// Somehow between here and when it sends back to the framework, it
102-
// bundles the two updates.
103-
Log.e("justin", "Android engine receiving from framework " + editingState.text);
10498
setTextInputEditingState(mView, editingState);
10599
}
106100

@@ -387,7 +381,6 @@ private void applyStateToSelection(TextInputChannel.TextEditState state) {
387381

388382
@VisibleForTesting
389383
void setTextInputEditingState(View view, TextInputChannel.TextEditState state) {
390-
// TODO(justinmc): Step 2.
391384
// Always replace the contents of mEditable if the text differs
392385
if (!state.text.equals(mEditable.toString())) {
393386
mEditable.replace(0, mEditable.length(), state.text);

0 commit comments

Comments
 (0)