This repository was archived by the owner on Feb 25, 2025. It is now read-only.
File tree Expand file tree Collapse file tree 2 files changed +0
-12
lines changed
shell/platform/android/io/flutter/plugin/editing Expand file tree Collapse file tree 2 files changed +0
-12
lines changed Original file line number Diff line number Diff line change @@ -154,8 +154,6 @@ private void updateEditingState() {
154
154
currentValue .composingStart ,
155
155
currentValue .composingEnd );
156
156
157
- // TODO(justinmc): This must be where the engine sends a value to the frmwk.
158
- Log .e ("justin" , "Android engine sending to framework " + currentValue .text );
159
157
textInputChannel .updateEditingState (
160
158
mClient ,
161
159
currentValue .text ,
@@ -190,9 +188,6 @@ public boolean beginBatchEdit() {
190
188
191
189
@ Override
192
190
public boolean endBatchEdit () {
193
- // TODO(justinmc): This is how Android is able to batch requests.
194
- // Should iOS do the same? Or is there another way to work around this?
195
- Log .e ("justin" , "endBatchEdit" );
196
191
boolean result = super .endBatchEdit ();
197
192
mBatchCount --;
198
193
updateEditingState ();
Original file line number Diff line number Diff line change 26
26
import androidx .annotation .NonNull ;
27
27
import androidx .annotation .Nullable ;
28
28
import androidx .annotation .VisibleForTesting ;
29
- import io .flutter .Log ;
30
29
import io .flutter .embedding .engine .systemchannels .TextInputChannel ;
31
30
import io .flutter .plugin .platform .PlatformViewsController ;
32
31
import java .util .HashMap ;
@@ -96,11 +95,6 @@ public void setPlatformViewClient(int platformViewId) {
96
95
97
96
@ Override
98
97
public void setEditingState (TextInputChannel .TextEditState editingState ) {
99
- // TODO(justinmc): I believe this is where the framework sends a
100
- // value to the engine.
101
- // Somehow between here and when it sends back to the framework, it
102
- // bundles the two updates.
103
- Log .e ("justin" , "Android engine receiving from framework " + editingState .text );
104
98
setTextInputEditingState (mView , editingState );
105
99
}
106
100
@@ -387,7 +381,6 @@ private void applyStateToSelection(TextInputChannel.TextEditState state) {
387
381
388
382
@ VisibleForTesting
389
383
void setTextInputEditingState (View view , TextInputChannel .TextEditState state ) {
390
- // TODO(justinmc): Step 2.
391
384
// Always replace the contents of mEditable if the text differs
392
385
if (!state .text .equals (mEditable .toString ())) {
393
386
mEditable .replace (0 , mEditable .length (), state .text );
You can’t perform that action at this time.
0 commit comments