Apply minor cleanups to Android embedding (#9088)

Eliminate an unused import, add missing @OverRide annotations, and
eliminate an unused logger.

Author: cbracken

shell/platform/android/io/flutter/embedding/engine/FlutterEnginePluginRegistry.java

@@ -97,6 +97,7 @@ public void destroy() {
     removeAll();
   }
 
+  @Override
   public void add(@NonNull FlutterPlugin plugin) {
     // Add the plugin to our generic set of plugins and notify the plugin
     // that is has been attached to an engine.
@@ -152,20 +153,24 @@ public void add(@NonNull FlutterPlugin plugin) {
     }
   }
 
+  @Override
   public void add(@NonNull Set<FlutterPlugin> plugins) {
     for (FlutterPlugin plugin : plugins) {
       add(plugin);
     }
   }
 
+  @Override
   public boolean has(@NonNull Class<? extends FlutterPlugin> pluginClass) {
     return plugins.containsKey(pluginClass);
   }
 
+  @Override
   public FlutterPlugin get(@NonNull Class<? extends FlutterPlugin> pluginClass) {
     return plugins.get(pluginClass);
   }
 
+  @Override
   public void remove(@NonNull Class<? extends FlutterPlugin> pluginClass) {
     FlutterPlugin plugin = plugins.get(pluginClass);
     if (plugin != null) {
@@ -220,12 +225,14 @@ public void remove(@NonNull Class<? extends FlutterPlugin> pluginClass) {
     }
   }
 
+  @Override
   public void remove(@NonNull Set<Class<? extends FlutterPlugin>> pluginClasses) {
     for (Class<? extends FlutterPlugin> pluginClass : pluginClasses) {
       remove(pluginClass);
     }
   }
 
+  @Override
   public void removeAll() {
     // We copy the keys to a new set so that we can mutate the set while using
     // the keys.
@@ -489,6 +496,7 @@ public FlutterEngineActivityPluginBinding(@NonNull Activity activity) {
      * Returns the {@link Activity} that is currently attached to the {@link FlutterEngine} that
      * owns this {@code ActivityPluginBinding}.
      */
+    @Override
     @NonNull
     public Activity getActivity() {
       return activity;
@@ -498,13 +506,15 @@ public Activity getActivity() {
      * Adds a listener that is invoked whenever the associated {@link Activity}'s
      * {@code onRequestPermissionsResult(...)} method is invoked.
      */
+    @Override
     public void addRequestPermissionsResultListener(@NonNull io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener listener) {
       onRequestPermissionsResultListeners.add(listener);
     }
 
     /**
      * Removes a listener that was added in {@link #addRequestPermissionsResultListener(io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener)}.
      */
+    @Override
     public void removeRequestPermissionsResultListener(@NonNull io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener listener) {
       onRequestPermissionsResultListeners.remove(listener);
     }
@@ -525,13 +535,15 @@ boolean onRequestPermissionsResult(int requestCode, @NonNull String[] permission
      * Adds a listener that is invoked whenever the associated {@link Activity}'s
      * {@code onActivityResult(...)} method is invoked.
      */
+    @Override
     public void addActivityResultListener(@NonNull io.flutter.plugin.common.PluginRegistry.ActivityResultListener listener) {
       onActivityResultListeners.add(listener);
     }
 
     /**
      * Removes a listener that was added in {@link #addActivityResultListener(io.flutter.plugin.common.PluginRegistry.ActivityResultListener)}.
      */
+    @Override
     public void removeActivityResultListener(@NonNull io.flutter.plugin.common.PluginRegistry.ActivityResultListener listener) {
       onActivityResultListeners.remove(listener);
     }
@@ -552,13 +564,15 @@ boolean onActivityResult(int requestCode, int resultCode, @NonNull Intent data)
      * Adds a listener that is invoked whenever the associated {@link Activity}'s
      * {@code onNewIntent(...)} method is invoked.
      */
+    @Override
     public void addOnNewIntentListener(@NonNull io.flutter.plugin.common.PluginRegistry.NewIntentListener listener) {
       onNewIntentListeners.add(listener);
     }
 
     /**
      * Removes a listener that was added in {@link #addOnNewIntentListener(io.flutter.plugin.common.PluginRegistry.NewIntentListener)}.
      */
+    @Override
     public void removeOnNewIntentListener(@NonNull io.flutter.plugin.common.PluginRegistry.NewIntentListener listener) {
       onNewIntentListeners.remove(listener);
     }
@@ -577,13 +591,15 @@ void onNewIntent(@Nullable Intent intent) {
      * Adds a listener that is invoked whenever the associated {@link Activity}'s
      * {@code onUserLeaveHint()} method is invoked.
      */
+    @Override
     public void addOnUserLeaveHintListener(@NonNull io.flutter.plugin.common.PluginRegistry.UserLeaveHintListener listener) {
       onUserLeaveHintListeners.add(listener);
     }
 
     /**
      * Removes a listener that was added in {@link #addOnUserLeaveHintListener(io.flutter.plugin.common.PluginRegistry.UserLeaveHintListener)}.
      */
+    @Override
     public void removeOnUserLeaveHintListener(@NonNull io.flutter.plugin.common.PluginRegistry.UserLeaveHintListener listener) {
       onUserLeaveHintListeners.remove(listener);
     }

shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java

@@ -29,9 +29,6 @@ class InputConnectionAdaptor extends BaseInputConnection {
     private InputMethodManager mImm;
     private final Layout mLayout;
 
-    private static final MethodChannel.Result logger =
-        new ErrorLogResult("FlutterTextInput");
-
     @SuppressWarnings("deprecation")
     public InputConnectionAdaptor(
         View view,

shell/platform/android/io/flutter/view/FlutterMain.java

@@ -4,7 +4,6 @@
 
 package io.flutter.view;
 
-import android.app.AlarmManager;
 import android.app.PendingIntent;
 import android.content.Context;
 import android.content.Intent;