Work-around called-once imprecision

This avoids (yet another) inconsistency from the imprecision of
called once. In this case the inlining of some methods that are
called once is dependent on whether we meet their call-site directly
or indirectly first, effectively making the inlining decision subject
to the enqueuing order.

Change-Id: I8d6b9c18fdb82f6d1b566e6bb58344211678daf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103631
Reviewed-by: Sigmund Cherem <[email protected]>

Author: johnniwinther

pkg/compiler/lib/src/js_model/js_strategy.dart

@@ -218,8 +218,6 @@ class KernelSsaBuilder implements SsaBuilder {
   final JsToElementMap _elementMap;
   final SourceInformationStrategy _sourceInformationStrategy;
 
-  // TODO(johnniwinther,sra): Inlining decisions should not be based on the
-  // order in which ssa graphs are built.
   FunctionInlineCache _inlineCache;
 
   KernelSsaBuilder(this._task, this._options, this._reporter,

pkg/compiler/lib/src/ssa/builder_kernel.dart

@@ -5711,7 +5711,12 @@ class KernelSsaGraphBuilder extends ir.Visitor {
         if (canInline) {
           _inlineCache.markAsInlinable(function, insideLoop: insideLoop);
         } else {
-          _inlineCache.markAsNonInlinable(function, insideLoop: insideLoop);
+          if (_isFunctionCalledOnce(function)) {
+            // TODO(34203): We can't update the decision due to imprecision in
+            // the calledOnce data, described in Issue 34203.
+          } else {
+            _inlineCache.markAsNonInlinable(function, insideLoop: insideLoop);
+          }
         }
       }
       return canInline;